Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

kie-issues#755: Fix kogito operator nightly deploy pipelines #1535

Merged
merged 18 commits into from
Jan 12, 2024

Conversation

rodrigonull
Copy link
Contributor

@rodrigonull rodrigonull commented Dec 15, 2023

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -55,7 +56,8 @@ pipeline {
}

// Verify we have the connectivity to Openshift
openshift.loginOpenshift()
// TODO: Uncomment this line when we have the Openshift credentials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we need to get them? Or is this in progress in any way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the OpenShift Instance is only used to run the tests. I'm not sure who has the credentials but we need to figure that out to add those credentials to Apache Jenkins.
@porcelli Do you know who can help us with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a OpenShift instance available, so better disable this

Copy link
Contributor

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rodrigonull
Copy link
Contributor Author

@porcelli I've made some changes to remove the code that publishes the operator image to the OpenShift registry and running the tests that require an OpenShift instance. The build is now passing as you can see in this test job:
https://ci-builds.apache.org/job/KIE/job/test/job/kie-issues_755/job/kie-issues_755/job/nightly/job/kogito-operator-deploy/9/.

We can revert it back if we have an available OpenShift instance in the future.

@rodrigonull rodrigonull merged commit 34a5aa1 into main Jan 12, 2024
1 of 2 checks passed
@rodrigonull rodrigonull deleted the kie-issues_755 branch January 29, 2024 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants