Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BXMSPROD-2076] fix prod branch job setup #1016

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[BXMSPROD-2076] fix prod branch job setup #1016

merged 1 commit into from
Jul 26, 2023

Conversation

lampajr
Copy link
Contributor

@lampajr lampajr commented Jul 19, 2023

@lampajr lampajr marked this pull request as ready for review July 19, 2023 13:18
@lampajr lampajr requested a review from radtriste July 19, 2023 13:18
radtriste
radtriste approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
About the -Dproductized, let's put it in the build-chain config and see later how it behaves ;)

@lampajr lampajr merged commit ea01e8a into apache:main Jul 26, 2023
@lampajr lampajr deleted the BXMSPROD-2076_prod_branch_fix branch July 26, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radtriste radtriste radtriste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lampajr @radtriste