Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting compare to non failure #1249

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

elguardian
Copy link
Contributor

No description provided.

@elguardian
Copy link
Contributor Author

@porcelli @martinweiler tyring to unstack work without compromising pr. This allows to know exactly which modules are failing and do in parallel thoses fixes if require. Once the module are fixed we can go on and set this to failure = true

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the exclusions as they are.
We already know those modules are not reproducible "by-design" - no need to waste time building them twice

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elguardian elguardian merged commit 5537388 into apache:main Sep 17, 2024
@elguardian elguardian deleted the validate-compare branch September 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants