BXMSPROD-1231 UMB message body with project version #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radtriste
reviewed
Jan 4, 2022
| @@ -72,7 +76,7 @@ pipeline { | |||
| stage('Generate Properties Files') { | |||
| steps { | |||
| script { | |||
| if(env.ALREADY_BUILT_PROJECTS?.trim()) { | |||
| if(PME_EXECUTION_RESULT?.size()) { | |||
There was a problem hiding this comment.
Suggested change
| if(PME_EXECUTION_RESULT?.size()) { | |
| if(PME_EXECUTION_RESULT) { |
should be enough there or ?
There was a problem hiding this comment.
could be the case where map is empty and if(PME_EXECUTION_RESULT) so the size will assure the PME_EXECUTION_RESULT will have real content
There was a problem hiding this comment.
well if map is empty, if(PME_EXECUTION_RESULT) will consider false
|
@Ginxo any status there ? |
Co-authored-by: Tristan Radisson <[email protected]>
|
@radtriste this is out of date I will propose a new one (most probably today) |
|
closed in favor of https://github.com/kiegroup/kogito-pipelines/pull/682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/BXMSPROD-1231
@radtriste just consider to change the QE side consuming the UMB message
from
builtProjects: ['projectA', 'projectB']tobuiltProjects: {'projectA': 'versionX', 'projectB': 'versionY'}