KOGITO-8410 Added support for Number and Boolean to GetRequestKnative…

…ParamsDecorator Signed-off-by: Helber Belmiro <[email protected]>
apache · Aug 14, 2023 · 447d1ac · 447d1ac
1 parent b31d488
commit 447d1ac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...gito/addons/quarkus/knative/serving/customfunctions/GetRequestKnativeParamsDecorator.java b/...gito/addons/quarkus/knative/serving/customfunctions/GetRequestKnativeParamsDecorator.java
@@ -30,6 +30,8 @@ public void decorate(KogitoWorkItem workItem, Map<String, Object> parameters, Ht
         KnativeFunctionPayloadSupplier.getPayload(parameters).forEach((key, value) -> {
             if (value instanceof String) {
                 request.addQueryParam(key, (String) value);
+            } else if (value instanceof Number || value instanceof Boolean) {
+                request.addQueryParam(key, String.valueOf(value));
             } else {
                 String message = "Knative functions support only GET requests with String attributes. {0} has a {1} value.";
                 throw new IllegalArgumentException(MessageFormat.format(message, key, value.getClass()));

diff --git a/.../addons/quarkus/knative/serving/customfunctions/GetRequestKnativeParamsDecoratorTest.java b/.../addons/quarkus/knative/serving/customfunctions/GetRequestKnativeParamsDecoratorTest.java
@@ -43,9 +43,11 @@ class GetRequestKnativeParamsDecoratorTest {
 
     @Test
     void decorate() {
-        Map<String, String> expectedParams = Map.of(
+        Map<String, Object> expectedParams = Map.of(
                 "key1", "value1",
-                "key2", "value2");
+                "key2", "value2",
+                "booleanParam", true,
+                "numberParam", 42);
 
         HttpRequest<?> request = createRequest();
 
@@ -54,12 +56,12 @@ void decorate() {
 
         decorator.decorate(null, parameters, request);
 
-        assertThat(request.queryParams()).hasSize(2);
-        expectedParams.forEach((k, v) -> assertThat(request.queryParams().get(k)).isEqualTo(v));
+        assertThat(request.queryParams()).hasSize(4);
+        expectedParams.forEach((k, v) -> assertThat(request.queryParams().get(k)).isEqualTo(String.valueOf(v)));
     }
 
     @Test
-    void decorateNonStringValuesShouldThrowException() {
+    void decorateInvalidTypeShouldThrowException() {
         Map<String, Object> expectedParams = Map.of(
                 "key1", "value1",
                 "key2", new Object());