[KOGITO-9584] Review comments and sonar warnings

apache · Jul 17, 2023 · abb3674 · abb3674
1 parent ddfd1d9
commit abb3674
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/...oyment/src/main/java/org/kie/kogito/serverless/workflow/parser/schema/JsonSchemaImpl.java b/...oyment/src/main/java/org/kie/kogito/serverless/workflow/parser/schema/JsonSchemaImpl.java
@@ -27,6 +27,8 @@
 import org.eclipse.microprofile.openapi.models.media.Schema;
 import org.kie.kogito.jackson.utils.ObjectMapperFactory;
 import org.kie.kogito.serverless.workflow.io.URIContentLoaderFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonInclude;
@@ -44,6 +46,8 @@
 @JsonInclude(JsonInclude.Include.NON_NULL)
 public class JsonSchemaImpl extends SchemaImpl {
 
+    private static final Logger logger = LoggerFactory.getLogger(JsonSchemaImpl.class);
+
     @JsonSetter("$ref")
     @Override
     public void setRef(String ref) {
@@ -63,6 +67,7 @@ public void setRef(String ref) {
                 ref = OpenApiConstants.REF_PREFIX_SCHEMA + key;
             } catch (URISyntaxException | IOException e) {
                 // if not a valid uri, let super handle it
+                logger.info("Error loading ref {}", ref, e);
             }
         }
         super.setRef(ref);

diff --git a/...deployment/src/main/java/org/kie/kogito/serverless/workflow/parser/schema/RefSchemas.java b/...deployment/src/main/java/org/kie/kogito/serverless/workflow/parser/schema/RefSchemas.java
@@ -27,11 +27,11 @@ private RefSchemas() {
     }
 
     private static class ThreadInfo {
-        public int counter;
-        public String id;
-        public Map<String, Schema> map = new HashMap<>();
+        private final String id;
+        private final Map<String, Schema> map = new HashMap<>();
+        private int counter;
 
-        public ThreadInfo(String id) {
+        private ThreadInfo(String id) {
             this.id = id;
         }
     }
@@ -52,6 +52,6 @@ public static String getKey() {
     }
 
     public static void reset() {
-        threadInfo.set(null);
+        threadInfo.remove();
     }
 }