[KOGITO-7959]-Handling Null pointer in Models class if write method does not exist #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
(tests) - kogito-runtimes job Test results:
Those are the test failures: org.kie.kogito.codegen.tests.VariableIT.testVariablesWithReservedNameOnServiceTaskorg.kie.kogito.ReflectiveModelAccessException: java.beans.IntrospectionException: Method not found: isPackageat org.kie.kogito.codegen.tests.VariableIT.testVariablesWithReservedNameOnServiceTask(VariableIT.java:43) Caused by: java.beans.IntrospectionException: Method not found: isPackage at org.kie.kogito.codegen.tests.VariableIT.testVariablesWithReservedNameOnServiceTask(VariableIT.java:43) |
fjtirado
reviewed
Nov 17, 2022
| @@ -77,8 +78,10 @@ public static <T> T fromMap(T m, Map<String, Object> map) { | |||
| for (Map.Entry<String, PropertyDescriptor> e : descriptors.entrySet()) { | |||
| String k = e.getKey(); | |||
| k = unprefixVar(k); | |||
| PropertyDescriptor pd = new PropertyDescriptor(k, m.getClass()); | |||
| Method writeMethod = pd.getWriteMethod(); | |||
There was a problem hiding this comment.
hmmm, e.getValue was already a property descriptor for key k, so I do not think this fixes the issue.
In order to determine that, you need to write a test that use a class without getter/setter but public fields
fjtirado
reviewed
Nov 17, 2022
| if (map.containsKey(k)) { | ||
| e.getValue().getWriteMethod().invoke(m, map.get(k)); | ||
| writeMethod.invoke(m, map.get(k)); |
There was a problem hiding this comment.
I think this will still be null if there is not setter for that field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira - https://issues.redhat.com/browse/KOGITO-7959
Handled the possible null pointer exception while accessing the write method in Models class.