Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-9500] - Remove pmml dependencies from SWF #3112

Closed
wants to merge 1 commit into from

Conversation

VaniHaripriya
Copy link
Contributor

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaniHaripriya Unfortunaltely I do not think this is the right approach to achieve the purpose of removing pmml from workflow.
why not trying to declare pmml-model as optional in jbpm-flow pom first, so we do not have to exclude it in several places?

@VaniHaripriya
Copy link
Contributor Author

@VaniHaripriya Unfortunaltely I do not think this is the right approach to achieve the purpose of removing pmml from workflow. why not trying to declare pmml-model as optional in jbpm-flow pom first, so we do not have to exclude it in several places?
@fjtirado Thank you Francisco, that approach looks more cleaner. Will create a new PR with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants