Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-9625: Upgrade quarkus-openapi-generator to 1.3.8 #3130

Merged
merged 3 commits into from
Jul 31, 2023
Merged

KOGITO-9625: Upgrade quarkus-openapi-generator to 1.3.8 #3130

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba0e0ca
KOGITO-9625: Upgrade quarkus-openapi-generator to 1.3.8
manstis Jul 24, 2023
c2633a8
Fix failing tests.
manstis Jul 26, 2023
7a9e0d0
Add Integration Test without Authorization headers to confirm X-Clien…
manstis Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kogito-build/kogito-dependencies-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<version.net.minidev.jsonsmart>2.4.10</version.net.minidev.jsonsmart>
<version.net.thisptr.jackson-jq>1.0.0-preview.20220705</version.net.thisptr.jackson-jq>
<version.io.quarkiverse.jackson-jq>1.1.0</version.io.quarkiverse.jackson-jq>
<version.io.quarkiverse.openapi.generator>1.2.1</version.io.quarkiverse.openapi.generator>
<version.io.quarkiverse.openapi.generator>1.3.8</version.io.quarkiverse.openapi.generator>
<version.io.quarkiverse.asyncapi>0.0.3</version.io.quarkiverse.asyncapi>
<version.io.quarkiverse.reactivemessaging.http>1.1.5</version.io.quarkiverse.reactivemessaging.http>
<version.io.quarkiverse.embedded.postgresql>0.0.8</version.io.quarkiverse.embedded.postgresql>
Expand Down
4 changes: 2 additions & 2 deletions ...ient/src/test/java/org/kie/kogito/quarkus/it/openapi/client/ApiWithSecurityContextIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void verifyAuthHeadersOpenApi2_0() {
// verify if the headers were correctly sent
authWithApiKeyServer2
.verify(postRequestedFor(urlEqualTo(AuthSecurityMockService.SEC_20.getPath()))
.withHeader("X-Client-Id", matching("12345"))
.withHeader("X-Client-Id", matching("Basic amF2aWVyaXRvOmZ1bGFuaXRv"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the client ID has the Basic Auth Token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini please see this.

The newer version of quarkus-openapi-generator changed the behaviour when Authorization headers are present.

The existing tests include these header and hence their expected results changed.

I added two new tests that do not include Authorization headers and reflect the old behaviour of the existing tests.

.withHeader("Authorization", matching("Basic amF2aWVyaXRvOmZ1bGFuaXRv")));
}

Expand All @@ -84,7 +84,7 @@ void verifyAuthHeadersOpenApi3_0() {

authWithApiKeyServer3
.verify(postRequestedFor(urlEqualTo(AuthSecurityMockService.SEC_30.getPath()))
.withHeader("X-Client-Id", matching("12345"))
.withHeader("X-Client-Id", matching("Bearer mytoken,Bearer mytoken,Bearer"))
.withHeader("Authorization", matching("Bearer mytoken")));
}

Expand Down
Loading