[KOGITO-9614] Fixing issue with async api and dev mode #3165

fjtirado · 2023-08-08T09:40:32Z

Reverted to previos version of async api base on code generation (since the alternative approach mengled with quarkus config management and make wrong assumption about resource location)
There is a degree of classpath manipulation that I cannot avoid but it should be fine since it only occurs while on devmode. Also there are some exception while cleanup test that I feel are acceptable since it does not affect the overal result

2023-08-08 11:49:05,475 ERROR [io.qua.sma.rea.run.dev.ReactiveMessagingHotReplacementSetup] (pool-39-thread-1) Failed to redeploy application on changes: java.lang.IllegalStateException: Cannot reset a started application
	at io.quarkus.dev.appstate.ApplicationStateNotification.reset(ApplicationStateNotification.java:20)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:90)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.restartApp(IsolatedDevModeMain.java:222)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.restartCallback(IsolatedDevModeMain.java:203)
	at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:537)
	at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:437)
	at io.quarkus.smallrye.reactivemessaging.runtime.devmode.ReactiveMessagingHotReplacementSetup$OnMessage$1.run(ReactiveMessagingHotReplacementSetup.java:44)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

…on (apache#3147)" This reverts commit decf232.

radtriste · 2023-08-08T09:42:47Z

jenkins run kogito-runtimes quarkus-lts

radtriste · 2023-08-08T09:43:15Z

jenkins run kogito-runtimes native

fjtirado · 2023-08-08T09:49:16Z

Jenkins run kogito-runtimes quarkus-lts

fjtirado · 2023-08-08T09:49:25Z

Jenkins run kogito-runtimes native

fjtirado · 2023-08-08T10:00:29Z

Jenkins run kogito-runtimes quarkus-lts

fjtirado · 2023-08-08T10:00:42Z

Jenkins run kogito-runtimes native

fjtirado · 2023-08-08T10:03:13Z

...ent/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIProcessor.java

-    KogitoBuildContextAttributeBuildItem asyncAPIContext(List<AsyncAPIBuildItem> asyncAPIBuildItem) {
-        return new KogitoBuildContextAttributeBuildItem(ParserContext.ASYNC_CONVERTER_KEY, new AsyncAPIInfoConverter(
-                new MapAsyncAPIRegistry(asyncAPIBuildItem.stream().map(AsyncAPIBuildItem::getAsyncAPI).collect(Collectors.toList()))));
+    void asyncAPIContext(LiveReloadExecutionBuildItem reload, KogitoBuildContextBuildItem context, BuildProducer<KogitoAddonsPreGeneratedSourcesBuildItem> sources) throws ClassNotFoundException {


LiveReload depends on KogitoBuildContext (which depends on KogitoContextAttributeBuildItem), so here the trick is to declare a producer (that actually does not produce anything) so this is invoked before kogito codegen and take benefit of the fact that KogitoBuildContext is a mutable class.
We need LiveReload to use the proper classloader when loading the service

kie-ci3 · 2023-08-08T10:30:55Z

(quarkus-lts) - kogito-runtimes job #90 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export QUARKUS_BRANCH=2.13
export BUILD_MVN_OPTS_CURRENT=-T 1C
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-runtimes -u https://github.com/kiegroup/kogito-runtimes/pull/3165 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest.quarkus-lts/job/kogito-runtimes.quarkus-lts.kogito-runtimes/90/display/redirect

Test results:

PASSED: 2206
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest.testAsyncApi

1 expectation failed.
Expected status code <201> but was <500>.

radtriste · 2023-08-08T13:12:37Z

@fjtirado https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest.quarkus-lts/job/kogito-runtimes.quarkus-lts.kogito-runtimes/90/testReport/org.kie.kogito.quarkus.serverless.workflow.deployment.livereload/LiveReloadProcessorTest/testAsyncApi/

Looks like the inheritance issue is still there ... is that related ?

fjtirado · 2023-08-08T15:28:04Z

@fjtirado https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest.quarkus-lts/job/kogito-runtimes.quarkus-lts.kogito-runtimes/90/testReport/org.kie.kogito.quarkus.serverless.workflow.deployment.livereload/LiveReloadProcessorTest/testAsyncApi/

Looks like the inheritance issue is still there ... is that related ?

I have my doubts, but now it is clear is not related with async api extension, but with the reload test.

fjtirado · 2023-08-08T15:44:55Z

...a/org/kie/kogito/addon/quarkus/messaging/common/message/CloudEventHttpOutgoingDecorator.java

@@ -25,7 +25,7 @@
 /**
 * Decorators for Http CloudEvents outgoing messages
 */
-public final class CloudEventHttpOutgoingDecorator implements MessageDecorator {
+public class CloudEventHttpOutgoingDecorator implements MessageDecorator {


@radtriste This is intending to fix the inheritance issue on lts

fjtirado · 2023-08-08T15:46:29Z

Jenkins run kogito-runtimes quarkus-lts

kie-ci3 · 2023-08-08T16:26:17Z

(tests) - kogito-runtimes job #2992 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

export BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-runtimes -u https://github.com/kiegroup/kogito-runtimes/pull/3165 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.kogito-runtimes/2992/display/redirect

Test results:

PASSED: 3350
FAILED: 1

Those are the test failures:

org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadMode

expected: 5
but was: 0

fjtirado · 2023-08-08T17:13:28Z

jenkins run kogito-runtimes tests

sonarcloud · 2023-08-08T17:50:20Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

91.4% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Revert "[KOGITO-9614] Kogito changes for new asyncapi extension versi…

8699087

…on (apache#3147)" This reverts commit decf232.

fjtirado requested review from hbelmiro and radtriste August 8, 2023 09:40

fjtirado force-pushed the KOGITO-9614a branch from aff9989 to 7dc865c Compare August 8, 2023 09:47

[KOGITO-9614] Async api and reload

9240a8a

fjtirado force-pushed the KOGITO-9614a branch from 7dc865c to 9240a8a Compare August 8, 2023 09:59

fjtirado commented Aug 8, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

hbelmiro approved these changes Aug 8, 2023

View reviewed changes

[KOGITO-9614] Changes after CI run

325da9a

fjtirado commented Aug 8, 2023

View reviewed changes

fjtirado merged commit 1b2146d into apache:main Aug 8, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KOGITO-9614] Fixing issue with async api and dev mode #3165

[KOGITO-9614] Fixing issue with async api and dev mode #3165

fjtirado commented Aug 8, 2023 •

edited

Loading

radtriste commented Aug 8, 2023

radtriste commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado Aug 8, 2023

This comment was marked as outdated.

This comment was marked as outdated.

kie-ci3 commented Aug 8, 2023

This comment was marked as outdated.

This comment was marked as outdated.

radtriste commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado Aug 8, 2023

fjtirado commented Aug 8, 2023

kie-ci3 commented Aug 8, 2023

fjtirado commented Aug 8, 2023

sonarcloud bot commented Aug 8, 2023

[KOGITO-9614] Fixing issue with async api and dev mode #3165

[KOGITO-9614] Fixing issue with async api and dev mode #3165

Conversation

fjtirado commented Aug 8, 2023 • edited Loading

radtriste commented Aug 8, 2023

radtriste commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado Aug 8, 2023

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

kie-ci3 commented Aug 8, 2023

This comment was marked as outdated.

This comment was marked as outdated.

radtriste commented Aug 8, 2023

fjtirado commented Aug 8, 2023

fjtirado Aug 8, 2023

Choose a reason for hiding this comment

fjtirado commented Aug 8, 2023

kie-ci3 commented Aug 8, 2023

fjtirado commented Aug 8, 2023

sonarcloud bot commented Aug 8, 2023

fjtirado commented Aug 8, 2023 •

edited

Loading