[KOGITO-9763] Adding metadata to node #3195
Conversation
| @@ -94,7 +92,7 @@ public T doGetProcessNodes(String processId) { | |||
| Map<String, Object> data = new HashMap<>(); | |||
| data.put("id", n.getId()); | |||
| data.put("uniqueId", ((Node) n).getUniqueId()); | |||
| data.put("nodeDefinitionId", n.getMetaData().get(UNIQUE_ID)); | |||
| data.put("metadata", n.getMetaData()); | |||
There was a problem hiding this comment.
Now that we are including all node metadata in the response, I think we can remove the nodeDefinitionId, which is kind of duplicated of uniqueId
|
(tests) - kogito-runtimes job Reproducerexport BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Test results:
Those are the test failures: org.kie.kogito.integrationtests.quarkus.ManagementAddOnIT.testGetProcessNodes1 expectation failed.JSON path [0].nodeDefinitionId doesn't match. Expected: not (null or an empty string) Actual: null org.kie.kogito.integrationtests.springboot.ManagementAddOnTest.testGetProcessNodes1 expectation failed.JSON path [0].nodeDefinitionId doesn't match. Expected: not (null or an empty string) Actual: null |
|
(tests) - serverless-workflow-examples job Reproducerexport BUILD_MVN_OPTS_CURRENT= NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Test results:
Those are the test failures: org.kie.kogito.examples.OpenVinoRestIT.testOpenvino1 expectation failed.JSON path workflowdata.group doesn't match. Expected: a string containing "flat-coated retriever" Actual: <[]> |
|
Kudos, SonarCloud Quality Gate passed! |
Adding state, action and branch metadata to each node.