[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at runtime #3252

tiagodolphine · 2023-10-16T17:12:24Z

Depends on
#3252
apache/incubator-kie-kogito-examples#1821
apache/incubator-kie-kogito-apps#1913

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

You have read the contributors guide
Your code is properly formatted according to this configuration
Pull Request title is properly formatted: KOGITO-XYZ Subject
Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
Pull Request contains link to the JIRA issue
Pull Request contains link to any dependent or related Pull Request
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ?

The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.

The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:

jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.

Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

ricardozanini · 2023-10-16T19:25:00Z

FYI the GHA is running now, these errors are related to the test itself.

nmirasch · 2023-10-17T08:33:56Z

...-services/src/main/java/org/kie/kogito/services/registry/ProcessDefinitionEventRegistry.java

@@ -0,0 +1,95 @@
+/*
+ * Copyright 2023 Red Hat, Inc. and/or its affiliates.


@tiagodolphine I think this header needs to be updated

nmirasch · 2023-10-17T08:36:18Z

api/kogito-events-api/src/main/java/org/kie/kogito/event/process/NodeDefinitionEventBody.java

@@ -0,0 +1,83 @@
+package org.kie.kogito.event.process;


@tiagodolphine missing header

nmirasch · 2023-10-17T08:37:34Z

...rkus-common/src/main/java/org/kie/kogito/quarkus/registry/ProcessDefinitionRegistration.java

@@ -0,0 +1,31 @@
+package org.kie.kogito.quarkus.registry;


@tiagodolphine missing header

nmirasch · 2023-10-17T08:38:01Z

api/kogito-events-core/src/main/java/org/kie/kogito/event/impl/ProcessEventBatch.java

@@ -0,0 +1,27 @@
+package org.kie.kogito.event.impl;


@tiagodolphine missing header

nmirasch · 2023-10-17T11:15:20Z

api/kogito-events-api/src/main/java/org/kie/kogito/event/process/NodeDefinitionEventBody.java

+
+import java.util.Map;
+
+public class NodeDefinitionEventBody {


@tiagodolphine regarding this is just a POJO and it is nott specifically the body of any event, I think it makes sense rename this class just to NodeDefinition, ProcessDefinitionNode.. or something similar. WDYT?

+1, indeed this is not an event body, so I'll rename it, thanks.

jstastny-cz · 2023-10-18T07:37:55Z

Jenkins failed with

[ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.13.0:validate (default) on project kogito-codegen-api: File '/home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3252/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-api/src/main/java/org/kie/kogito/codegen/api/context/impl/SpringBootKogitoBuildContext.java' has not been previously formatted.  Please format file and commit before running validation! -> [Help 1]

kie-ci3 · 2023-10-18T17:10:10Z

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3252 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3252/8/display/redirect

Test results:

PASSED: 3263
FAILED: 1

Those are the test failures:

org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTest

expected: not equal but was: <0>

...s/events/process/runtime/src/main/java/org/kie/kogito/events/config/EventsRuntimeConfig.java

api/kogito-api/src/main/java/org/kie/kogito/event/EventPublisher.java

wmedvede · 2023-10-19T08:52:10Z

...boot/addons/events/kafka/src/main/java/org/kie/kogito/events/spring/KafkaEventPublisher.java

@@ -53,6 +49,9 @@ public class KafkaEventPublisher implements EventPublisher {
    @Value("${kogito.events.processinstances.enabled:true}")
    private boolean processInstancesEvents;

+    @Value("${kogito.events.process-definition.enabled:true}")


same comment here regading the naming of this property

@tiagodolphine just a reminder, I believe this renaming is pending.

I missed this one, thanks.

...-services/src/main/java/org/kie/kogito/services/registry/ProcessDefinitionEventRegistry.java

wmedvede

I've left some minor comments in case they can be useful.
good job.

kie-ci3 · 2023-10-19T22:24:00Z

PR job #11 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3252 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3252/11/display/redirect

Test results:

PASSED: 3377
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo

Expected size: 1 but was: 2 in:
{"age"=666, "name"="javieritoPerson"}

…time

…endency check

…a on events

kie-ci3 · 2023-11-21T19:59:03Z

PR job #23 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3252 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3252/23/display/redirect

Test results:

PASSED: 3391
FAILED: 2

Those are the test failures:

org.kie.kogito.mongodb.transaction.AbstractTransactionManagerIT.testAbort

Command failed with error 246 (SnapshotUnavailable): 'Unable to read from a snapshot due to pending collection catalog changes; please retry the operation. Snapshot timestamp is Timestamp(1700585679, 0). Collection minimum is Timestamp(1700585679, 2)' on server 172.17.0.1:34002. The full response is {"errorLabels": ["TransientTransactionError"], "operationTime": {"$timestamp": {"t": 1700585678, "i": 2}}, "ok": 0.0, "errmsg": "Unable to read from a snapshot due to pending collection catalog changes; please retry the operation. Snapshot timestamp is Timestamp(1700585679, 0). Collection minimum is Timestamp(1700585679, 2)", "code": 246, "codeName": "SnapshotUnavailable", "$clusterTime": {"clusterTime": {"$timestamp": {"t": 1700585680, "i": 1}}, "signature": {"hash": {"$binary": {"base64": "AAAAAAAAAAAAAAAAAAAAAAAAAAA=", "subType": "00"}}, "keyId": 0}}}

org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo

Expecting value to be true but was false

tiagodolphine · 2023-11-22T19:14:34Z

@nmirasch @wmedvede want to take another round of review? or are we ok to merge?

…untime (apache#3252) * KOGITO-9886 Add the support for the ProcessDefinitionDataEvent at runtime

tiagodolphine requested review from fjtirado and wmedvede October 16, 2023 17:15

tiagodolphine requested a review from ricardozanini October 16, 2023 20:03

nmirasch reviewed Oct 17, 2023

View reviewed changes

wmedvede reviewed Oct 19, 2023

View reviewed changes

...s/events/process/runtime/src/main/java/org/kie/kogito/events/config/EventsRuntimeConfig.java Outdated Show resolved Hide resolved

wmedvede reviewed Oct 19, 2023

View reviewed changes

api/kogito-api/src/main/java/org/kie/kogito/event/EventPublisher.java Outdated Show resolved Hide resolved

wmedvede reviewed Oct 19, 2023

View reviewed changes

...-services/src/main/java/org/kie/kogito/services/registry/ProcessDefinitionEventRegistry.java Outdated Show resolved Hide resolved

wmedvede reviewed Oct 19, 2023

View reviewed changes

tiagodolphine force-pushed the KOGITO-9886 branch from cbde742 to a5d8e8a Compare October 19, 2023 13:19

tiagodolphine force-pushed the KOGITO-9886 branch from dddf50f to d7af0b0 Compare November 1, 2023 15:45

tiagodolphine marked this pull request as ready for review November 1, 2023 19:23

tiagodolphine mentioned this pull request Nov 7, 2023

[KOGITO-9886] adding workflow definitions events configuration apache/incubator-kie-kogito-examples#1821

Merged

7 tasks

wmedvede approved these changes Nov 13, 2023

View reviewed changes

tiagodolphine force-pushed the KOGITO-9886 branch from 455d655 to c6eda2f Compare November 14, 2023 19:23

tiagodolphine mentioned this pull request Nov 16, 2023

[KOGITO-9886] fix IT for data-index and jobs-service with process-definitions events apache/incubator-kie-kogito-apps#1913

Merged

7 tasks

tiagodolphine added 6 commits November 21, 2023 16:14

KOGITO-9886 Add the support for the ProcessDefinitionDataEvent at run…

3160609

…time

Extracting the logic to build the process name in the utils class

e5d7a4b

fix formatting

2c3821b

applying pr comments

fc6793d

fix headers + concurrent issue on IT

b3423a0

concurrent issue on IT

e3bc599

tiagodolphine added 12 commits November 21, 2023 16:14

Fixing formatter issues

97703be

Fixing formatter issues

70b6244

adding annotation, description, to the process definition event

08932a8

fixes after rebase + applying pr comments

4cd1c08

adding process-management-deployment addon in the IT to fix maven dep…

0632460

…endency check

publishign defintion on data index devservice and fix data type/schem…

ebfd69d

…a on events

adding config in knative addon

66c0852

minor fixes

7bbc75d

fix imports

79a9b40

adding uniqueId and type for node definition

3291838

fix header and dependency on springboot it

9121b66

fix to broken CI gha springboot archetype

fbcd5b2

tiagodolphine force-pushed the KOGITO-9886 branch from 573cebc to fbcd5b2 Compare November 21, 2023 20:07

adjust invoker config

6f3a2d8

nmirasch approved these changes Nov 23, 2023

View reviewed changes

tiagodolphine merged commit adec9f0 into apache:main Nov 23, 2023
6 checks passed

rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Dec 13, 2023

[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at r…

3b80d86

…untime (apache#3252) * KOGITO-9886 Add the support for the ProcessDefinitionDataEvent at runtime

fjtirado pushed a commit to fjtirado/kogito-runtimes that referenced this pull request Jan 10, 2024

[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at r…

70f2665

…untime (apache#3252) * KOGITO-9886 Add the support for the ProcessDefinitionDataEvent at runtime

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at runtime #3252

[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at runtime #3252

tiagodolphine commented Oct 16, 2023 •

edited

Loading

ricardozanini commented Oct 16, 2023

nmirasch Oct 17, 2023

nmirasch Oct 17, 2023

nmirasch Oct 17, 2023

nmirasch Oct 17, 2023

nmirasch Oct 17, 2023

tiagodolphine Oct 17, 2023

jstastny-cz commented Oct 18, 2023

kie-ci3 commented Oct 18, 2023

wmedvede Oct 19, 2023

wmedvede Nov 13, 2023

tiagodolphine Nov 13, 2023

wmedvede left a comment

kie-ci3 commented Oct 19, 2023

kie-ci3 commented Nov 21, 2023

tiagodolphine commented Nov 22, 2023

		@@ -0,0 +1,95 @@
		/*
		* Copyright 2023 Red Hat, Inc. and/or its affiliates.

[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at runtime #3252

[KOGITO-9886] Add the support for the ProcessDefinitionDataEvent at runtime #3252

Conversation

tiagodolphine commented Oct 16, 2023 • edited Loading

ricardozanini commented Oct 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jstastny-cz commented Oct 18, 2023

kie-ci3 commented Oct 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wmedvede left a comment

Choose a reason for hiding this comment

kie-ci3 commented Oct 19, 2023

kie-ci3 commented Nov 21, 2023

tiagodolphine commented Nov 22, 2023

tiagodolphine commented Oct 16, 2023 •

edited

Loading