-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues#3320 Flaky timeout tests #3321
Merged
mariofusco
merged 1 commit into
apache:quarkus-3.2LTS
from
tkobayas:quarkus-3.2LTS-disable-timeout
Dec 11, 2023
Merged
issues#3320 Flaky timeout tests #3321
mariofusco
merged 1 commit into
apache:quarkus-3.2LTS
from
tkobayas:quarkus-3.2LTS-disable-timeout
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disabled until they get fixed/stable
nmirasch
approved these changes
Dec 7, 2023
mariofusco
approved these changes
Dec 7, 2023
@mariofusco @nmirasch Please merge this, thanks! |
tkobayas
added a commit
to tkobayas/kogito-runtimes
that referenced
this pull request
Dec 14, 2023
- Disabled until they get fixed/stable
mariofusco
pushed a commit
that referenced
this pull request
Dec 15, 2023
- Disabled until they get fixed/stable
mariofusco
added a commit
that referenced
this pull request
Dec 15, 2023
* Bump to Quarkus 3.2.9.Final * [Quarkus 3] Updated rewrite data * fixed quarkus3 patches * Apply patches * wip : fix jakarta.validation-api version * TEMPORARY: adjust pipeline config * CI - limit generated jobs * CI: update mvn and jdk in GHA * Fixing_ForEachRestIT (#3304) * Fixing_ForEachRestIT * Formatting * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (#3303) * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon * `keycloak-spring-boot-starter` removal in favour of springboot ouath2 * IT test fixes * upgrade `quarkus-embedded-postgresql` version * A property that use to be optional is now mandatory. * Formatting (#3306) MVn sort imports alphabetically, Jakarta is now before Java * Fix #3308 - Configure SpringBoot Kubernetes to add Client in test context (#3311) * Fix #3308 - Configure SpringBoot Kubernetes to add Client in test context Signed-off-by: Ricardo Zanini <[email protected]> * Add rockd temps to gitignore Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> * issues#3320 Flaky timeout tests (#3321) - Disabled until they get fixed/stable * Using different topics (#3322) * Fixing Fabric8 version alignment on Quarkus and SB (#3324) Signed-off-by: Ricardo Zanini <[email protected]> * Cancel should not interrupt current thread (#3325) * Do not interrut in CancelActionCommand (#3326) * There is not need to to do that check (#3329) * - Removing @lazy injections on RestWorkItemHandler constructors (#3330) * wip --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Toshiya Kobayashi <[email protected]> Co-authored-by: jstastny-cz <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Pere Fernández <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
fjtirado
added a commit
to fjtirado/kogito-runtimes
that referenced
this pull request
Jan 10, 2024
* Bump to Quarkus 3.2.9.Final * [Quarkus 3] Updated rewrite data * fixed quarkus3 patches * Apply patches * wip : fix jakarta.validation-api version * TEMPORARY: adjust pipeline config * CI - limit generated jobs * CI: update mvn and jdk in GHA * Fixing_ForEachRestIT (apache#3304) * Fixing_ForEachRestIT * Formatting * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (apache#3303) * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon * `keycloak-spring-boot-starter` removal in favour of springboot ouath2 * IT test fixes * upgrade `quarkus-embedded-postgresql` version * A property that use to be optional is now mandatory. * Formatting (apache#3306) MVn sort imports alphabetically, Jakarta is now before Java * Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context (apache#3311) * Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context Signed-off-by: Ricardo Zanini <[email protected]> * Add rockd temps to gitignore Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> * issues#3320 Flaky timeout tests (apache#3321) - Disabled until they get fixed/stable * Using different topics (apache#3322) * Fixing Fabric8 version alignment on Quarkus and SB (apache#3324) Signed-off-by: Ricardo Zanini <[email protected]> * Cancel should not interrupt current thread (apache#3325) * Do not interrut in CancelActionCommand (apache#3326) * There is not need to to do that check (apache#3329) * - Removing @lazy injections on RestWorkItemHandler constructors (apache#3330) * wip --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Toshiya Kobayashi <[email protected]> Co-authored-by: jstastny-cz <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Pere Fernández <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Jan 17, 2024
* Bump to Quarkus 3.2.9.Final * [Quarkus 3] Updated rewrite data * fixed quarkus3 patches * Apply patches * wip : fix jakarta.validation-api version * TEMPORARY: adjust pipeline config * CI - limit generated jobs * CI: update mvn and jdk in GHA * Fixing_ForEachRestIT (apache#3304) * Fixing_ForEachRestIT * Formatting * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (apache#3303) * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon * `keycloak-spring-boot-starter` removal in favour of springboot ouath2 * IT test fixes * upgrade `quarkus-embedded-postgresql` version * A property that use to be optional is now mandatory. * Formatting (apache#3306) MVn sort imports alphabetically, Jakarta is now before Java * Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context (apache#3311) * Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context Signed-off-by: Ricardo Zanini <[email protected]> * Add rockd temps to gitignore Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> * issues#3320 Flaky timeout tests (apache#3321) - Disabled until they get fixed/stable * Using different topics (apache#3322) * Fixing Fabric8 version alignment on Quarkus and SB (apache#3324) Signed-off-by: Ricardo Zanini <[email protected]> * Cancel should not interrupt current thread (apache#3325) * Do not interrut in CancelActionCommand (apache#3326) * There is not need to to do that check (apache#3329) * - Removing @lazy injections on RestWorkItemHandler constructors (apache#3330) * wip --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Toshiya Kobayashi <[email protected]> Co-authored-by: jstastny-cz <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Pere Fernández <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Closed
yesamer
pushed a commit
to yesamer/kogito-runtimes
that referenced
this pull request
Apr 22, 2024
* Bump to Quarkus 3.2.9.Final * [Quarkus 3] Updated rewrite data * fixed quarkus3 patches * Apply patches * wip : fix jakarta.validation-api version * TEMPORARY: adjust pipeline config * CI - limit generated jobs * CI: update mvn and jdk in GHA * Fixing_ForEachRestIT (apache#3304) * Fixing_ForEachRestIT * Formatting * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon (apache#3303) * kie-issues#262: Spring-Boot 3.0.5 migration: Fix SVG Addon * `keycloak-spring-boot-starter` removal in favour of springboot ouath2 * IT test fixes * upgrade `quarkus-embedded-postgresql` version * A property that use to be optional is now mandatory. * Formatting (apache#3306) MVn sort imports alphabetically, Jakarta is now before Java * Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context (apache#3311) * Fix apache#3308 - Configure SpringBoot Kubernetes to add Client in test context Signed-off-by: Ricardo Zanini <[email protected]> * Add rockd temps to gitignore Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> * issues#3320 Flaky timeout tests (apache#3321) - Disabled until they get fixed/stable * Using different topics (apache#3322) * Fixing Fabric8 version alignment on Quarkus and SB (apache#3324) Signed-off-by: Ricardo Zanini <[email protected]> * Cancel should not interrupt current thread (apache#3325) * Do not interrut in CancelActionCommand (apache#3326) * There is not need to to do that check (apache#3329) * - Removing @lazy injections on RestWorkItemHandler constructors (apache#3330) * wip --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Toshiya Kobayashi <[email protected]> Co-authored-by: jstastny-cz <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Pere Fernández <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3320
These tests are flaky. Even if I set a longer timeout value (e.g. from 10 sec to 60 sec), the tests may still fail.
Disabling tests is a temporal workaround to make CI healthy. Those tests should be re-enabled after getting stabilized.
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
Quarkus-3 PR check is failing ... what to do ?
The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.The first patch, called
0001_before_sh.patch
, is generated from Openrewrite.ci/environments/quarkus-3/quarkus3.yml
recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.No panic, there is an easy way to regenerate it. You just need to comment on the PR:
and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.