Process test migration from v7 legacy runtime to code generation (Issue #1131) #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @Abhitocode few notes in here: your branch should be called as the issue in this case "incubator-kie-issues-1131" the subjects needs to change to [incubator-kie-issues-1131] Process test migration from v7 legacy runtime to code generation the rest of the comments inline |
elguardian
reviewed
May 13, 2024
| @@ -936,6 +950,7 @@ public void testBusinessRuleTaskWithContionalEvent() throws Exception { | |||
| assertThat(list).hasSize(1); | |||
| } | |||
|
|
|||
| // The model does not have set myVar | |||
There was a problem hiding this comment.
avoid to add noise in here. If you want to annotate something like this won't be migrated but was want to focus attention to it. just add
@category with something like V7_ENGINE
There was a problem hiding this comment.
Okay, will make the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated some BPMN processes which are being compiled using legacy v7 to code generation approach.
The tests can be identified by referring to Activitytest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java
Issue: apache/incubator-kie-issues#1131