[incubator-kie-issues-1131] Improve DataOutput tests within DataTest.Java adding assert statement #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhitocode
changed the title
Abhitocode
changed the title
|
failures not related. |
martinweiler
requested changes
Aug 23, 2024
|
Hi @martinweiler, will check the same and update on the same. |
Abhitocode
force-pushed
the
incubator-kie-issues-1131-15
branch
from
7496aa6
to
fc8d1c0
Compare
martinweiler
approved these changes
Aug 30, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All testdataOutput tests within DataTest.java misses assert statement that actually evaluates the functionality. Add the assert statements and verify.
Tests can be identified by referring to:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java#L389