[incubator-kie-issues-1131] test migration from V7 to code generation-18

[Abhitocode]

In addition to previous changes associated,
Migrated tests within SLAComplianceTest.java

The test can be identified by referring to SLAComplianceTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/SLAComplianceTest.java

Closes apache/incubator-kie-issues#1131.

[kie-ci3]

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3622 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3622/1/display/redirect

Test results:

• PASSED: 3294
• FAILED: 3

Those are the test failures:

org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolated

[SLA was not violated while it is expected]
Expecting value to be true but was false

org.jbpm.bpmn2.SLAComplianceTest.testSLAonCatchEventViolated

[SLA should be violated by timer]
Expecting value to be true but was false

org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolated

[SLA was not violated while it is expected]
Expecting value to be true but was false

[elguardian]

LGTM

[martinweiler]

@Abhitocode I get test failures, am I missing some other code change required?

$ (cd jbpm/jbpm-tests/ && mvn test -Dtest=SLAComplianceTest)
...
[ERROR] Failures: 
[ERROR]   SLAComplianceTest.testSLAonCatchEventViolated:322 [SLA should be violated by timer] 
Expecting value to be true but was false
[ERROR]   SLAComplianceTest.testSLAonProcessViolated:77 [SLA was not violated while it is expected] 
Expecting value to be true but was false
[ERROR]   SLAComplianceTest.testSLAonUserTaskViolated:130 [SLA was not violated while it is expected] 
Expecting value to be true but was false
[INFO] 
[ERROR] Tests run: 9, Failures: 3, Errors: 0, Skipped: 0

[Abhitocode]

Hi @martinweiler When we run test cases individually they are all passing but when we run whole test class those 3 are failing.

Assessment: I suspect this is due to concurrency or timing issues. I tried adjusting the countdown latch and timer, but neither worked. I also used a single latch variable across all test cases and applied the @execution annotation, but nothing resolved the issue. When the whole test class is run, latch.await() is not completing. If we use latch.await() with a maximum time limit yet returns false. Your guidance would be helpful.

[Abhitocode]

The duplicate assert is removed for testSLAonUserTaskMet, might have overlooked before, thanks for catching that. Updated the same.