-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues-1131] test migration from V7 to code generation-20 #3627
[incubator-kie-issues-1131] test migration from V7 to code generation-20 #3627
Conversation
751d093
to
b179328
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3627 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/3/display/redirect Test results:
Those are the test failures: |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3627 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/2/display/redirect Test results:
Those are the test failures: org.kie.kogito.process.dynamic.DynamicCallResourceTest.testConcurrentDynamicCallsjava.lang.AssertionError: 1 expectation failed.Expected status code <200> but was <400>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
plz be aware of the CI failing |
b179328
to
1982b6a
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3627 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/4/display/redirect Test results:
Those are the test failures: org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2Expected size: 2 but was: 1 in: [EventDesciption [event=timerTriggered, nodeId=_4, nodeName=timer, eventType=timer, nodeInstanceId=e9261cd5-dcef-4689-9553-feae88c1cbe9, processInstanceId=dc3f100b-5879-4f3d-80d2-854ee09f6cb5, dataType=null, properties={TimerID=c5c33f3b-2355-4c8f-879a-f59c8c7550c8, Period=null, Delay=500ms, Date=null}]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Abhitocode
In addition to previous changes associated,
Migrated tests within FlowTest.java
The test can be identified by referring to FlowTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java
Closes apache/incubator-kie-issues#1131.