Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1131] test migration from V7 to code generation-20 #3627

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Abhitocode
Copy link
Contributor

In addition to previous changes associated,
Migrated tests within FlowTest.java

The test can be identified by referring to FlowTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java

Closes apache/incubator-kie-issues#1131.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 21, 2024

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3627 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/3/display/redirect

Test results:

  • PASSED: 3355
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.FlowTest.testMultipleGatewaysProcess
expected: 2
but was: 1

@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 21, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3627 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/2/display/redirect

Test results:

  • PASSED: 3353
  • FAILED: 3

Those are the test failures:

org.jbpm.bpmn2.FlowTest.testMultipleGatewaysProcess
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3
expected: 3
but was: 2
org.kie.kogito.process.dynamic.DynamicCallResourceTest.testConcurrentDynamicCalls java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <400>.

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elguardian elguardian marked this pull request as ready for review August 21, 2024 07:38
@elguardian
Copy link
Contributor

plz be aware of the CI failing

@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 22, 2024

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3627 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/4/display/redirect

Test results:

  • PASSED: 3355
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
Expected size: 2 but was: 1 in:
[EventDesciption [event=timerTriggered, nodeId=_4, nodeName=timer, eventType=timer, nodeInstanceId=e9261cd5-dcef-4689-9553-feae88c1cbe9, processInstanceId=dc3f100b-5879-4f3d-80d2-854ee09f6cb5, dataType=null, properties={TimerID=c5c33f3b-2355-4c8f-879a-f59c8c7550c8, Period=null, Delay=500ms, Date=null}]]

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Abhitocode

@elguardian elguardian merged commit 1aec3ea into apache:main Aug 29, 2024
5 of 6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
4 participants