-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues-1131] test migration from V7 to code generation-26 #3650
base: main
Are you sure you want to change the base?
Conversation
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3650 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3650/1/display/redirect Test results:
Those are the test failures: org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolated[SLA was not violated while it is expected]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedNoTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolated[SLA was not violated while it is expected]Expecting value to be true but was false |
a7ab0bb
to
3efde7f
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3650 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3650/2/display/redirect Test results:
Those are the test failures: org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedExternalTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolated[SLA was not violated while it is expected]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonCatchEventViolated[SLA should be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolatedExternalTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedNoTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolated[SLA was not violated while it is expected]Expecting value to be true but was false io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes. |
@Abhitocode fix the conflict. |
3efde7f
to
c3eec24
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3650 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3650/3/display/redirect Test results:
Those are the test failures: org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedExternalTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolated[SLA was not violated while it is expected]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonCatchEventViolated[SLA should be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolatedExternalTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedNoTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolated[SLA was not violated while it is expected]Expecting value to be true but was false |
c3eec24
to
e0cec66
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3650 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3650/4/display/redirect Test results:
Those are the test failures: org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedExternalTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolated[SLA was not violated while it is expected]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonCatchEventViolated[SLA should be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolatedExternalTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonProcessViolatedNoTracking[SLA should not be violated by timer]Expecting value to be true but was false org.jbpm.bpmn2.SLAComplianceTest.testSLAonUserTaskViolated[SLA was not violated while it is expected]Expecting value to be true but was false io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTestExpecting value to be false but was true org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval |
Below are the migrated tests in IntermediateEventTest.java and SLAComplianceTest.java.
They pass if the test is run inividually but fail when whole class is run.
Tried to resolve using @after and @before methods so that the tests would be isolated but did not work.
The test can be identified by referring to:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/SLAComplianceTest.java
Closes apache/incubator-kie-issues#1131.