Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1457] Allow grouping of events #3654

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Aug 31, 2024

@fjtirado fjtirado force-pushed the incubator-kie-issues#1457 branch 2 times, most recently from 767b563 to e3735f1 Compare August 31, 2024 09:03
@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 31, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3654 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3654/2/display/redirect

Test results:

  • PASSED: 3223
  • FAILED: 12

Those are the test failures:

org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateWithError
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateSuccessful
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateWithError
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateTimeoutsSuccessful
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateWithError
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateTimeoutsSuccessful
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.PojoServiceIT.testTypesPojo
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.PojoServiceIT.testFilterPojo
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowEvents java.util.concurrent.TimeoutException
at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
at org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowEvents(WorkflowEventIT.java:118)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowDefinitionsEvents Assertion condition defined as a org.kie.kogito.quarkus.workflows.WorkflowEventIT
Expected size: 57 but was: 0 in:
[] within 10 seconds.
org.kie.kogito.integrationtests.quarkus.ProcessEventIT.testSaveTask java.util.concurrent.TimeoutException
at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
at org.kie.kogito.integrationtests.quarkus.ProcessEventIT.testSaveTask(ProcessEventIT.java:200)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 31, 2024

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3654 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3654/3/display/redirect

Test results:

  • PASSED: 3223
  • FAILED: 12

Those are the test failures:

org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateWithError
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateSuccessful
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateWithError
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateTimeoutsSuccessful
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateWithError
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateTimeoutsSuccessful
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.PojoServiceIT.testTypesPojo
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.PojoServiceIT.testFilterPojo
Expecting value to be true but was false
org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowEvents java.util.concurrent.TimeoutException
at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
at org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowEvents(WorkflowEventIT.java:118)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowDefinitionsEvents Assertion condition defined as a org.kie.kogito.quarkus.workflows.WorkflowEventIT
Expected size: 57 but was: 0 in:
[] within 10 seconds.
org.kie.kogito.integrationtests.quarkus.ProcessEventIT.testSaveTask java.util.concurrent.TimeoutException
at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
at org.kie.kogito.integrationtests.quarkus.ProcessEventIT.testSaveTask(ProcessEventIT.java:200)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@kie-ci3
Copy link
Contributor

kie-ci3 commented Sep 17, 2024

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3654 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3654/5/display/redirect

Test results:

  • PASSED: 3349
  • FAILED: 9

Those are the test failures:

org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishEmptyEventsCollection
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): userTasksEventsEmitter, processInstanceEmitter, processDefinitionEventsEmitter, processInstancesEventsEmitter, userTaskEmitter, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testReactiveMessagingEventPublisher_publish
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstanceEmitter, processDefinitionEventsEmitter, userTasksEventsEmitter, processInstancesEventsEmitter, userTaskEmitter, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testGroupingMessagingEventPublisher_publish
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstanceEmitter, processInstancesEventsEmitter, decoratedMessage, processDefinitionEventsEmitter, userTasksEventsEmitter, userTaskEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishGroupingByChannel
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): decoratedMessage, processInstancesEventsEmitter, processInstanceEmitter, userTasksEventsEmitter, userTaskEmitter, processDefinitionEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishToTopic_ExceptionHandling
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): decoratedMessage, userTaskEmitter, processInstancesEventsEmitter, processDefinitionEventsEmitter, userTasksEventsEmitter, processInstanceEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishMultipleEventsGroupedByChannel
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, processDefinitionEventsEmitter, userTasksEventsEmitter, processInstanceEmitter, userTaskEmitter, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishToTopicWithDecorator
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): userTasksEventsEmitter, userTaskEmitter, decoratedMessage, processDefinitionEventsEmitter, processInstancesEventsEmitter, processInstanceEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testDecorateMessage
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): decoratedMessage, processInstanceEmitter, userTaskEmitter, processInstancesEventsEmitter, userTasksEventsEmitter, processDefinitionEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testNoConsumersFound
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): userTasksEventsEmitter, processInstancesEventsEmitter, processDefinitionEventsEmitter, userTaskEmitter, processInstanceEmitter, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Sep 18, 2024

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3654 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3654/6/display/redirect

Test results:

  • PASSED: 3349
  • FAILED: 13

Those are the test failures:

org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testNullEventInCollection
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processDefinitionEventsEmitter, decoratedMessage, processInstanceConsumer, userTasksEventsEmitter, userTaskConsumer, processInstancesEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishEmptyEventsCollection
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processDefinitionEventsEmitter, userTaskConsumer, processInstanceConsumer, decoratedMessage, userTasksEventsEmitter, processInstancesEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testReactiveMessagingEventPublisher_publish
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, processDefinitionEventsEmitter, userTaskConsumer, processInstanceConsumer, decoratedMessage, userTasksEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testGroupingMessagingEventPublisher_publish
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, userTaskConsumer, userTasksEventsEmitter, processDefinitionEventsEmitter, decoratedMessage, processInstanceConsumer.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishUnsupportedEventType
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processDefinitionEventsEmitter, userTasksEventsEmitter, decoratedMessage, processInstancesEventsEmitter, userTaskConsumer, processInstanceConsumer.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishGroupingByChannel
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, userTasksEventsEmitter, processInstanceConsumer, processDefinitionEventsEmitter, userTaskConsumer, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishWithMultipleEventTypesSomeWithoutConsumers
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): userTaskConsumer, processInstanceConsumer, processInstancesEventsEmitter, processDefinitionEventsEmitter, userTasksEventsEmitter, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishToTopic_ExceptionHandling
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, processDefinitionEventsEmitter, userTasksEventsEmitter, decoratedMessage, processInstanceConsumer, userTaskConsumer.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishMultipleEventsGroupedByChannel
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstanceConsumer, decoratedMessage, processDefinitionEventsEmitter, processInstancesEventsEmitter, userTasksEventsEmitter, userTaskConsumer.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testPublishToTopicWithDecorator
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, userTaskConsumer, userTasksEventsEmitter, decoratedMessage, processInstanceConsumer, processDefinitionEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testDecorateMessage
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstancesEventsEmitter, userTasksEventsEmitter, userTaskConsumer, processDefinitionEventsEmitter, processInstanceConsumer, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testEventsDisabledInConfig
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): userTasksEventsEmitter, processInstancesEventsEmitter, userTaskConsumer, processInstanceConsumer, decoratedMessage, processDefinitionEventsEmitter.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.
org.kie.kogito.events.process.GroupingMessagingEventPublisherTest.testNoConsumersFound
Mockito couldn't inject mock dependency on field 'private org.kie.kogito.events.process.AbstractMessagingEventPublisher$AbstractMessageEmitter org.kie.kogito.events.process.AbstractMessagingEventPublisher.processDefinitionConsumer' that is annotated with @Injectmocks in your test,
because there were multiple matching mocks (i.e. fields annotated with @mock and having matching type): processInstanceConsumer, processInstancesEventsEmitter, processDefinitionEventsEmitter, userTasksEventsEmitter, userTaskConsumer, decoratedMessage.
If you have multiple fields of same type in your class under test then consider naming the @mock fields identically to the respective class under test's fields, so Mockito can match them by name.

@fjtirado fjtirado force-pushed the incubator-kie-issues#1457 branch 4 times, most recently from 6f87c85 to 6b58fcd Compare September 26, 2024 11:11
@kie-ci3
Copy link
Contributor

kie-ci3 commented Sep 26, 2024

PR job #11 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3654 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3654/11/display/redirect

Test results:

  • PASSED: 3156
  • FAILED: 4

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1
org.kie.kogito.addon.quarkus.messaging.common.message.http.CloudEventHttpOutgoingDecoratorTest.verifyOutgoingHttpMetadataIsSet java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: jakarta.enterprise.inject.spi.DeploymentException: Found 2 deployment problems:
[1] Unsatisfied dependency for type io.quarkus.tls.TlsConfigurationRegistry and qualifiers [@default]
- injection target: io.quarkus.reactivemessaging.http.runtime.QuarkusWebSocketConnector#tlsRegistry
- declared on CLASS bean [types=[org.eclipse.microprofile.reactive.messaging.spi.ConnectorFactory, io.quarkus.reactivemessaging.http.runtime.QuarkusWebSocketConnector, org.eclipse.microprofile.reactive.messaging.spi.OutgoingConnectorFactory, org.eclipse.microprofile.reactive.messaging.spi.IncomingConnectorFactory, java.lang.Object], qualifiers=[@Any, @connector("quarkus-websocket")], target=io.quarkus.reactivemessaging.http.runtime.QuarkusWebSocketConnector]
[2] Unsatisfied dependency for type io.quarkus.tls.TlsConfigurationRegistry and qualifiers [@default]
- injection target: io.quarkus.reactivemessaging.http.runtime.QuarkusHttpConnector#tlsRegistry
- declared on CLASS bean [types=[org.eclipse.microprofile.reactive.messaging.spi.ConnectorFactory, io.quarkus.reactivemessaging.http.runtime.QuarkusHttpConnector, org.eclipse.microprofile.reactive.messaging.spi.OutgoingConnectorFactory, org.eclipse.microprofile.reactive.messaging.spi.IncomingConnectorFactory, java.lang.Object], qualifiers=[@Any, @connector("quarkus-http")], target=io.quarkus.reactivemessaging.http.runtime.QuarkusHttpConnector]
at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1516)
at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:320)
at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:160)
at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:488)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:840)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Suppressed: jakarta.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.tls.TlsConfigurationRegistry and qualifiers [@default]
- injection target: io.quarkus.reactivemessaging.http.runtime.QuarkusWebSocketConnector#tlsRegistry
- declared on CLASS bean [types=[org.eclipse.microprofile.reactive.messaging.spi.ConnectorFactory, io.quarkus.reactivemessaging.http.runtime.QuarkusWebSocketConnector, org.eclipse.microprofile.reactive.messaging.spi.OutgoingConnectorFactory, org.eclipse.microprofile.reactive.messaging.spi.IncomingConnectorFactory, java.lang.Object], qualifiers=[@Any, @connector("quarkus-websocket")], target=io.quarkus.reactivemessaging.http.runtime.QuarkusWebSocketConnector]
at io.quarkus.arc.processor.Beans.resolveInjectionPoint(Beans.java:518)
at io.quarkus.arc.processor.BeanInfo.init(BeanInfo.java:638)
at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:308)
... 13 more
Suppressed: jakarta.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.tls.TlsConfigurationRegistry and qualifiers [@default]
- injection target: io.quarkus.reactivemessaging.http.runtime.QuarkusHttpConnector#tlsRegistry
- declared on CLASS bean [types=[org.eclipse.microprofile.reactive.messaging.spi.ConnectorFactory, io.quarkus.reactivemessaging.http.runtime.QuarkusHttpConnector, org.eclipse.microprofile.reactive.messaging.spi.OutgoingConnectorFactory, org.eclipse.microprofile.reactive.messaging.spi.IncomingConnectorFactory, java.lang.Object], qualifiers=[@Any, @connector("quarkus-http")], target=io.quarkus.reactivemessaging.http.runtime.QuarkusHttpConnector]
at io.quarkus.arc.processor.Beans.resolveInjectionPoint(Beans.java:518)
at io.quarkus.arc.processor.BeanInfo.init(BeanInfo.java:638)
at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:308)
... 13 more

@fjtirado fjtirado force-pushed the incubator-kie-issues#1457 branch 2 times, most recently from 9f062d8 to 2a219b7 Compare September 26, 2024 21:00
@fjtirado fjtirado marked this pull request as ready for review September 26, 2024 22:35
@@ -52,7 +52,7 @@
<version.io.quarkiverse.jackson-jq>2.0.2</version.io.quarkiverse.jackson-jq>
<version.io.quarkiverse.openapi.generator>2.4.1</version.io.quarkiverse.openapi.generator>
<version.io.quarkiverse.asyncapi>0.3.0</version.io.quarkiverse.asyncapi>
<version.io.quarkiverse.reactivemessaging.http>2.2.0</version.io.quarkiverse.reactivemessaging.http>
<version.io.quarkiverse.reactivemessaging.http>2.4.1</version.io.quarkiverse.reactivemessaging.http>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to include a fix on connector deserialization

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astounding work @fjtirado ! This is a great enhancement for performance, thanks!

@fjtirado fjtirado merged commit a7044d0 into apache:main Oct 4, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 10, 2024
* [Fix apache/incubator-kie-issues#1457] Allow grouping of events

* Add test for coverage

* [Fix apache/incubator-kie-issues#1457] Grouping of event serialization

* [Fix apache/incubator-kie-issues#1457] Adding default constructor

* [Fix apache/incubator-kie-issues#1457] Adding TYPE constant

---------

Co-authored-by: gmunozfe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ReactiveEventPublisher throughtput
4 participants