Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3694] Avoid generation of fake ProcessInstanceVariableDataEvent #3696

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Oct 4, 2024

Fix #3694
Access to loop variable in for each state is now performed as variable (using "$") rather than as property (using ".")
To be merged with apache/incubator-kie-kogito-examples#2019

@gmunozfe gmunozfe self-requested a review October 9, 2024 12:30
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great improvement also for performance and fixes an incorrect concept of the specification, thx @fjtirado !

@fjtirado fjtirado merged commit f41d4fd into apache:main Oct 10, 2024
6 of 11 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonNodeContext is generating unneeded event for context variables
3 participants