Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator-kie-issues-1520] Proper user task exception handling #3705

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[incubator-kie-issues-1520] Proper user task exception handling #3705

merged 2 commits into from
Oct 11, 2024

Conversation

elguardian
Copy link
Contributor

@elguardian elguardian self-assigned this Oct 8, 2024
@apache apache deleted a comment from kie-ci3 Oct 8, 2024
martinweiler
martinweiler reviewed Oct 8, 2024
View reviewed changes
...ocesses/src/main/resources/class-templates/usertask/RestResourceUserTaskQuarkusTemplate.java Outdated
@@ -22,7 +22,7 @@
import java.util.List;
import java.util.Collection;

import jakarta.ws.rs.NotFoundException;
import jakarta.ws.rs.UserTaskInstanceNotFoundException;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have slipped in as a find/replace error.

martinweiler
martinweiler approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix required, otherwise good to go! Thanks @elguardian

@apache apache deleted a comment from kie-ci3 Oct 10, 2024
@apache apache deleted a comment from kie-ci3 Oct 10, 2024
@elguardian elguardian merged commit d2d0f2f into apache:main Oct 11, 2024
4 of 6 checks passed
@elguardian elguardian deleted the incubator-kie-issues-1520 branch October 11, 2024 10:17
@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 11, 2024

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3705 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3705/4/display/redirect

Test results:

  • PASSED: 3369
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3
expected: 3
but was: 2

rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 24, 2024
@elguardian @rgdoliveira
[incubator-kie-issues-1520] Proper user task exception handling (apac…
702f76d 
…he#3705)

* [incubator-kie-issues-1520] Proper user task exception handling

* fix quarkus exception resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pefernan pefernan pefernan approved these changes

@martinweiler martinweiler martinweiler approved these changes

Assignees

@elguardian elguardian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper user task exception handling
4 participants
@elguardian @kie-ci3 @martinweiler @pefernan