Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #3709] Inject action node should be cloned before merge #3710

Merged
merged 3 commits into from
Oct 10, 2024
Merged

[Fix #3709] Inject action node should be cloned before merge #3710

merged 3 commits into from
Oct 10, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Oct 8, 2024

Fix #3709

@fjtirado fjtirado changed the title [Fix #3709] Allow cloning when source node is the merge result [Fix #3709] Inject action node should be cloned before merge Oct 8, 2024
gmunozfe
gmunozfe approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @fjtirado !
A small change in code that leads a great improvement in performance for this kind of workflows like hello-world example

@fjtirado fjtirado merged commit 045300f into apache:main Oct 10, 2024
6 checks passed
domhanak
domhanak reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 10, 2024
@fjtirado @rgdoliveira
[Fix apache#3709] Inject action node should be cloned before merge (a…
b887866 
…pache#3710)

* [Fix apache#3709] Allow cloning when source node is the merge result

* Revert "[Fix apache#3709] Allow cloning when source node is the merge result"

This reverts commit f0a9cba.

* [Fix apache#3709] Clone node when injecting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domhanak domhanak domhanak left review comments

@gmunozfe gmunozfe gmunozfe approved these changes

@ricardozanini ricardozanini Awaiting requested review from ricardozanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combination of InjectAction and empty Input parameters generate a memory leak
3 participants
@fjtirado @gmunozfe @domhanak