Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Add license header #3714

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Oct 10, 2024

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

@@ -1,4 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko Not sure we can add the Apache license in the BMPN and DMN xsd files and related..., that because those are generated by OMG, therefore those should considered external assets, and not "ours".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@jomarko
Copy link
Contributor Author

jomarko commented Oct 11, 2024

Failed test:

2024-10-10T19:08:00.2886599Z [ERROR] Tests run: 49, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 5.927 s <<< FAILURE! -- in org.jbpm.bpmn2.StandaloneBPMNProcessTest
2024-10-10T19:08:00.2888692Z [ERROR] org.jbpm.bpmn2.StandaloneBPMNProcessTest.testEventBasedSplit2 -- Time elapsed: 0.531 s <<< FAILURE!
2024-10-10T19:08:00.2890152Z org.opentest4j.AssertionFailedError: 
2024-10-10T19:08:00.2890583Z 
2024-10-10T19:08:00.2890733Z expected: 2
2024-10-10T19:08:00.2891102Z  but was: 1
2024-10-10T19:08:00.2891989Z 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2024-10-10T19:08:00.2893744Z 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
2024-10-10T19:08:00.2895699Z 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
2024-10-10T19:08:00.2897403Z 	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
2024-10-10T19:08:00.2898780Z 	at org.jbpm.bpmn2.StandaloneBPMNProcessTest.testEventBasedSplit2(StandaloneBPMNProcessTest.java:407)
2024-10-10T19:08:00.2900004Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2024-10-10T19:08:00.2900922Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-10-10T19:08:00.2901884Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 11, 2024

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3714 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3714/3/display/redirect

Test results:

  • PASSED: 3369
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1

@jomarko
Copy link
Contributor Author

jomarko commented Oct 11, 2024

Running locally mvn clean install -Dfull -Prun-code-coverage -Dtest=IntermediateEventTest does not reproduce the test failure.

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure the builds are green (disregarding flaky tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants