Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1545]: Create JPA persistence layer for Human Tasks #3735

Merged
merged 11 commits into from
Oct 24, 2024

Conversation

pefernan
Copy link
Contributor

@pefernan pefernan commented Oct 17, 2024

Closes apache/incubator-kie-issues#1545

Ensemble:
#3735
apache/incubator-kie-kogito-examples#2028

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pefernan pefernan changed the title [WIP] incubator-kie-issues#1545: Create JPA persistence layer for Human Tasks incubator-kie-issues#1545: Create JPA persistence layer for Human Tasks Oct 22, 2024
@apache apache deleted a comment from kie-ci3 Oct 22, 2024
@apache apache deleted a comment from kie-ci3 Oct 22, 2024
@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 22, 2024

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3735 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3735/5/display/redirect

Test results:

  • PASSED: 3447
  • FAILED: 6

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1
PR check / Build projects / org.jbpm.userTask.jpa.it.UserTaskCommentsIT.testUserTaskComments 1 expectation failed.
JSON path $.size() doesn't match.
Expected: is <1>
Actual: <2>
PR check / Build projects / org.jbpm.userTask.jpa.it.UserTaskLifeCycleIT.testUserTaskLifeCycle 1 expectation failed.
Expected status code <200> but was <500>.
PR check / Build projects / org.jbpm.userTask.jpa.it.UserTaskLifeCycleIT.testUserTaskLifeCycle 1 expectation failed.
Expected status code <200> but was <500>.

@pefernan pefernan changed the title incubator-kie-issues#1545: Create JPA persistence layer for Human Tasks [incubator-kie-issues#1545]: Create JPA persistence layer for Human Tasks Oct 22, 2024
@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 22, 2024

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3735 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3735/6/display/redirect

Test results:

  • PASSED: 2570
  • FAILED: 3

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1

@pefernan
Copy link
Contributor Author

Added some logs to verify an error only reproducible in CI

- fix it tests endpoints
@apache apache deleted a comment from kie-ci3 Oct 22, 2024
@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 22, 2024

PR job #10 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3735 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3735/10/display/redirect

Test results:

  • PASSED: 3454
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo
Expected size: 1 but was: 2 in:
{"age"=666, "name"="javierito"}

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 23, 2024

PR job #11 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3735 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3735/11/display/redirect

Test results:

  • PASSED: 3454
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3 Index 0 out of bounds for length -1

@pefernan pefernan merged commit cd850e1 into apache:main Oct 24, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 7, 2024
…asks (apache#3735)

* incubator-kie-issues#1545: Create JPA persistence layer for Human Tasks
* - testing
* - springboot and it tests
* - cleanup
* - fix query
* - fix packages
 *- fix it tests endpoints
* - increase priority
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create JPA persistence layer for Human Tasks
4 participants