Skip to content

Commit

Permalink
Change error wrapping in test as function errors.Join() is not suppor…
Browse files Browse the repository at this point in the history
…ted in golang 1.19

Signed-off-by: Jordi Gil <[email protected]>
  • Loading branch information
jordigilh committed Dec 27, 2023
1 parent 66f50f1 commit 8b2d477
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/e2e/workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ package e2e
import (
"bytes"
"encoding/json"
"errors"
"fmt"
"math/rand"
"net/url"
Expand Down Expand Up @@ -384,7 +383,7 @@ func verifyHealthStatusInPod(name string, namespace string) {
Expect(h.Status).To(Equal(upStatus))
return
}
errs = errors.Join(err)
errs = fmt.Errorf("%w; %w", err, errs)

Check failure on line 386 in test/e2e/workflow_test.go

View workflow job for this annotation

GitHub Actions / End-to-end tests (Minikube)

fmt.Errorf call has more than one error-wrapping directive %w

Check failure on line 386 in test/e2e/workflow_test.go

View workflow job for this annotation

GitHub Actions / Check files generation

fmt.Errorf call has more than one error-wrapping directive %w

Check failure on line 386 in test/e2e/workflow_test.go

View workflow job for this annotation

GitHub Actions / Unit tests And Coverage

fmt.Errorf call has more than one error-wrapping directive %w
}
Expect(errs).NotTo(HaveOccurred(), fmt.Sprintf("No container was found that could respond to the health endpoint %v", errs))

Expand Down

0 comments on commit 8b2d477

Please sign in to comment.