Make migrateDBOnStartUp property optional

apache · Sep 4, 2024 · a9f18aa · a9f18aa
1 parent 1e7aad1
commit a9f18aa
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 26 deletions.
diff --git a/api/v1alpha08/sonataflow_persistence_types.go b/api/v1alpha08/sonataflow_persistence_types.go
@@ -52,6 +52,8 @@ type PersistenceOptionsSpec struct {
 	PostgreSQL *PersistencePostgreSQL `json:"postgresql,omitempty"`
 
 	// Whether to migrate database on service startup?
+	// +optional
+	// +default: false
 	MigrateDBOnStartUp bool `json:"migrateDBOnStartUp"`
 }
 

diff --git a/bundle/manifests/sonataflow.org_sonataflowplatforms.yaml b/bundle/manifests/sonataflow.org_sonataflowplatforms.yaml
@@ -628,8 +628,6 @@ spec:
                             required:
                             - secretRef
                             type: object
-                        required:
-                        - migrateDBOnStartUp
                         type: object
                       podTemplate:
                         description: PodTemplate describes the deployment details
@@ -8505,8 +8503,6 @@ spec:
                             required:
                             - secretRef
                             type: object
-                        required:
-                        - migrateDBOnStartUp
                         type: object
                       podTemplate:
                         description: PodTemplate describes the deployment details

diff --git a/bundle/manifests/sonataflow.org_sonataflows.yaml b/bundle/manifests/sonataflow.org_sonataflows.yaml
@@ -2163,8 +2163,6 @@ spec:
                     required:
                     - secretRef
                     type: object
-                required:
-                - migrateDBOnStartUp
                 type: object
               podTemplate:
                 description: PodTemplate describes the deployment details of this

diff --git a/config/crd/bases/sonataflow.org_sonataflowplatforms.yaml b/config/crd/bases/sonataflow.org_sonataflowplatforms.yaml
@@ -629,8 +629,6 @@ spec:
                             required:
                             - secretRef
                             type: object
-                        required:
-                        - migrateDBOnStartUp
                         type: object
                       podTemplate:
                         description: PodTemplate describes the deployment details
@@ -8506,8 +8504,6 @@ spec:
                             required:
                             - secretRef
                             type: object
-                        required:
-                        - migrateDBOnStartUp
                         type: object
                       podTemplate:
                         description: PodTemplate describes the deployment details

diff --git a/config/crd/bases/sonataflow.org_sonataflows.yaml b/config/crd/bases/sonataflow.org_sonataflows.yaml
@@ -2164,8 +2164,6 @@ spec:
                     required:
                     - secretRef
                     type: object
-                required:
-                - migrateDBOnStartUp
                 type: object
               podTemplate:
                 description: PodTemplate describes the deployment details of this

diff --git a/controllers/sonataflowplatform_controller_test.go b/controllers/sonataflowplatform_controller_test.go
@@ -261,14 +261,10 @@ func TestSonataFlowPlatformController(t *testing.T) {
 		ksp.Spec = v1alpha08.SonataFlowPlatformSpec{
 			Services: &v1alpha08.ServicesPlatformSpec{
 				DataIndex: &v1alpha08.ServiceSpec{
-					Persistence: &v1alpha08.PersistenceOptionsSpec{
-						MigrateDBOnStartUp: false,
-					},
+					Persistence: &v1alpha08.PersistenceOptionsSpec{},
 				},
 				JobService: &v1alpha08.ServiceSpec{
-					Persistence: &v1alpha08.PersistenceOptionsSpec{
-						MigrateDBOnStartUp: false,
-					},
+					Persistence: &v1alpha08.PersistenceOptionsSpec{},
 				},
 			},
 			Persistence: &v1alpha08.PlatformPersistenceOptionsSpec{

diff --git a/operator.yaml b/operator.yaml
@@ -1120,8 +1120,6 @@ spec:
                             required:
                             - secretRef
                             type: object
-                        required:
-                        - migrateDBOnStartUp
                         type: object
                       podTemplate:
                         description: PodTemplate describes the deployment details
@@ -8997,8 +8995,6 @@ spec:
                             required:
                             - secretRef
                             type: object
-                        required:
-                        - migrateDBOnStartUp
                         type: object
                       podTemplate:
                         description: PodTemplate describes the deployment details
@@ -19070,8 +19066,6 @@ spec:
                     required:
                     - secretRef
                     type: object
-                required:
-                - migrateDBOnStartUp
                 type: object
               podTemplate:
                 description: PodTemplate describes the deployment details of this

diff --git a/test/testdata/workflow/persistence/by_service/04-sonataflow_callbackstatetimeouts.sw.yaml b/test/testdata/workflow/persistence/by_service/04-sonataflow_callbackstatetimeouts.sw.yaml
@@ -21,7 +21,6 @@ metadata:
     sonataflow.org/version: 0.0.1
 spec:
   persistence:
-    migrateDBOnStartUp: false
     postgresql:
       secretRef:
         name: postgres-secrets

diff --git a/...sistence/from_platform_overwritten_by_service/03-sonataflow_callbackstatetimeouts.sw.yaml b/...sistence/from_platform_overwritten_by_service/03-sonataflow_callbackstatetimeouts.sw.yaml
@@ -21,7 +21,6 @@ metadata:
     sonataflow.org/version: 0.0.1
 spec:
   persistence:
-    migrateDBOnStartUp: false
     postgresql:
       secretRef:
         name: postgres-secrets