Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-9103] [KSW-Operator] Create the cekit image descriptor for Op… #145

Merged
merged 13 commits into from
Sep 27, 2023

Conversation

davidesalerno
Copy link
Contributor

@davidesalerno davidesalerno commented May 31, 2023

…erator bundle image

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@davidesalerno davidesalerno force-pushed the KOGITO-9103 branch 11 times, most recently from cdfaea9 to 7cd164d Compare June 5, 2023 08:55
@davidesalerno davidesalerno marked this pull request as ready for review June 5, 2023 11:55
@davidesalerno davidesalerno changed the title WIP [KOGITO-9103] [KSW-Operator] Create the cekit image descriptor for Op… [KOGITO-9103] [KSW-Operator] Create the cekit image descriptor for Op… Jun 5, 2023
Makefile.osl Show resolved Hide resolved
Makefile.osl Outdated Show resolved Hide resolved
Makefile.osl Show resolved Hide resolved
@kie-ci
Copy link

kie-ci commented Jun 20, 2023

Openshift tests job #39 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-serverless-operator-PR-check/39/display/redirect
See console log:

Console Logs [2/2] STEP 4/10: LABEL description="Runtime Image for the Operator" io.cekit.version="4.7.0" summary="Runtime Image for the Operator"
[2/2] STEP 5/10: USER root
[2/2] STEP 6/10: RUN [ ! -d /tmp/scripts ] || rm -rf /tmp/scripts
[2/2] STEP 7/10: RUN [ ! -d /tmp/artifacts ] || rm -rf /tmp/artifacts
[2/2] STEP 8/10: USER 1001
[2/2] STEP 9/10: WORKDIR /usr/local/bin
[2/2] STEP 10/10: ENTRYPOINT ["manager"]
[2/2] COMMIT sonataflow-serverless-operator:2.0.0-snapshot
Getting image source signatures
Copying blob sha256:4deb43649c6646648232e22a083fede21435efe5a0bbef767edf7034715444d1
Copying blob sha256:aa23ff5cc4433df8af2867758040c4b3a9dd2e13b5f97aed8d9331bc78d0b387
Copying config sha256:33471612c4f316af63f5cc36e4e81b810126c80cb77e2a404008ed0bed93250c
Writing manifest to image destination
Storing signatures
--> 33471612c4f
Successfully tagged localhost/sonataflow-serverless-operator:2.0.0-snapshot
Successfully tagged localhost/sonataflow-serverless-operator:latest
33471612c4f316af63f5cc36e4e81b810126c80cb77e2a404008ed0bed93250c
�[32m2023-06-20 17:11:23,973 podman.py:62 INFO Image built and available under following tags: sonataflow-serverless-operator:2.0.0-snapshot, sonataflow-serverless-operator:latest�[0m
�[32m2023-06-20 17:11:23,974 cli.py:501 INFO Finished!�[0m
podman tag kogito-serverless-operator image-registry.openshift-image-registry.svc:5000/openshift/kogito-serverless-operator:pr-991fe9d
Error: kogito-serverless-operator: image not known
make: *** [Makefile:184: container-build] Error 125
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Push Operator Image(s) to Openshift Registry)
Stage "Push Operator Image(s) to Openshift Registry" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Run e2e tests)
Stage "Run e2e tests" skipped due to earlier failure(s)
[Pipeline] stage
[Pipeline] { (Running e2e tests)
Stage "Run e2e tests" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-serverless-operator-PR-check/39/api/json
[Pipeline] readJSON
[Pipeline] sh

@mareknovotny
Copy link

what is holding this PR from merging? Is there any remaining work here? Do you know @ricardozanini ?

@ricardozanini
Copy link
Member

@mareknovotny there are a few questions unanswered by Davide. I'll take this work since it looks like we don't have anyone else to do this work. But on my timeframe.

@mareknovotny
Copy link

i guess @davidesalerno can answer them if they are needed ;)

@spolti
Copy link
Member

spolti commented Sep 25, 2023

@mareknovotny there are a few questions unanswered by Davide. I'll take this work since it looks like we don't have anyone else to do this work. But on my timeframe.

I think we can merge this one as address any minor issue later.
As it refers to prod builds only, it would not affect the current releases nor introduce bugs.

@davidesalerno davidesalerno force-pushed the KOGITO-9103 branch 5 times, most recently from 4795c92 to 7e0b7c9 Compare September 26, 2023 15:11
@davidesalerno
Copy link
Contributor Author

@ricardozanini I reported here the answers we agreed on in our pasts weekly alignments.
I think that as soon as the CVP tests are fine we should merge this PR and eventually open some improvement tasks to tweak some points (like the Makefile, if it is possible) because doing everything in one shot it is blocking this change and it is taking a lot of efforts to regaling it to the latest main version every time.

@ricardozanini
Copy link
Member

@davidesalerno sure thing, just let me know when it's ready.

@davidesalerno davidesalerno force-pushed the KOGITO-9103 branch 3 times, most recently from b503798 to b11c551 Compare September 27, 2023 14:20
davidesalerno and others added 13 commits September 27, 2023 16:44
Signed-off-by: Davide Salerno <[email protected]>
Co-authored-by: Tristan Radisson <[email protected]>
@ricardozanini ricardozanini merged commit 4db8845 into apache:main Sep 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants