Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-9428]Update Operator SDK from 1.25 to 1.31 #165

Closed
wants to merge 3 commits into from

Conversation

desmax74
Copy link
Contributor

@desmax74 desmax74 commented Jun 21, 2023

See: https://issues.redhat.com/browse/KOGITO-9428

and related:
operator-framework/operator-sdk#6285
operator-framework/operator-sdk#6419

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@desmax74
Copy link
Contributor Author

/hold

@desmax74 desmax74 added the hold label Jun 21, 2023
@desmax74 desmax74 force-pushed the KOGITO-9428 branch 2 times, most recently from 5e27a30 to 0cd54bf Compare June 21, 2023 16:43
@apache apache deleted a comment from kie-ci Jun 21, 2023
@apache apache deleted a comment from kie-ci Jun 21, 2023
@apache apache deleted a comment from kie-ci Jun 21, 2023
@apache apache deleted a comment from kie-ci Jun 21, 2023
@apache apache deleted a comment from kie-ci Jun 21, 2023
@desmax74 desmax74 marked this pull request as draft June 21, 2023 17:13
@apache apache deleted a comment from kie-ci Jun 22, 2023
@apache apache deleted a comment from kie-ci Jun 22, 2023
@apache apache deleted a comment from kie-ci Jun 22, 2023
@apache apache deleted a comment from kie-ci Jun 22, 2023
@apache apache deleted a comment from kie-ci Jun 22, 2023
@apache apache deleted a comment from kie-ci Jun 22, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@apache apache deleted a comment from kie-ci Jun 23, 2023
@@ -262,7 +262,7 @@ bundle-build: ## Build the bundle image.

.PHONY: bundle-push
bundle-push: ## Push the bundle image.
$(MAKE) contianer-push IMG=$(BUNDLE_IMG)
$(MAKE) container-push IMG=$(BUNDLE_IMG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems simple enough 🤔
We can merge this after 1.41.x release since we might cherrypick/fix bugs for TP1 up until there. It will be easier for us if the SDK version remains the same for this work.

hack/checkCreatedAtAnnotation.sh Outdated Show resolved Hide resolved
@apache apache deleted a comment from kie-ci Jul 3, 2023
@desmax74 desmax74 changed the title [KOGITO-9428]Update Operator SDK from 1.25 to 1.30 [KOGITO-9428]Update Operator SDK from 1.25 to 1.31 Jul 31, 2023
@desmax74 desmax74 force-pushed the KOGITO-9428 branch 4 times, most recently from 8d89a7f to ea851a7 Compare July 31, 2023 07:32
@apache apache deleted a comment from kie-ci Jul 31, 2023
@apache apache deleted a comment from kie-ci Jul 31, 2023
@apache apache deleted a comment from kie-ci Jul 31, 2023
@apache apache deleted a comment from kie-ci Jul 31, 2023
@ricardozanini
Copy link
Member

Please hold until #185

@apache apache deleted a comment from kie-ci Jul 31, 2023
check_file=$(expr "$changed_files" == "M bundle/manifests/sonataflow-operator.clusterserviceversion.yaml")

if [[ "$check_file" == "0" ]] ; then
##@TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

letfover ?

Copy link
Contributor Author

@desmax74 desmax74 Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, fixed

changed_files=$(git status -s)
check_file=$(expr "$changed_files" == "M bundle/manifests/sonataflow-operator.clusterserviceversion.yaml")

if [[ "$check_file" == "0" ]] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is the specific use case where only that file is changed right ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small comment on what it does ? (apart from the issues above)

@spolti
Copy link
Member

spolti commented Aug 30, 2023

can we hold until we get https://github.com/kiegroup/kogito-serverless-operator/pull/239 merged?

MarianMacik pushed a commit to MarianMacik/kogito-serverless-operator that referenced this pull request Oct 3, 2023
@domhanak
Copy link
Contributor

@ricardozanini looks stale, how to proceed with this PR?

@ricardozanini
Copy link
Member

@ricardozanini looks stale, how to proceed with this PR?

This is relevant, but I'm holding off until we settle on the features being introduced at the moment. There are many requests for features atm and upgrading the base SDK may lead to many errors since we have many collaborators atm.

@ricardozanini
Copy link
Member

The code base changed a lot from this last iteration. @desmax74 do you think you can rebase? Otherwise, I'll upgrade to the latest in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants