[1.42.x] KOGITO-8276: Improve the logging adding missing levels #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* KOGITO-8276: Improve the logging adding missing levels * Add support for -zap-log-level CLI flag * Fix function invocation. * Updates following peer review. * Updates following peer review x2. Remove use of logger argument. * Remove klog.InitFlags(nil) in Logger wrappers. * Run make generate-all * Another refactor removing wrappers and contexts. * More updates. * Enable Info logging by default. * Add missing klog dependency. * Fix erroneous logging statements. * Move to structured logging. * Remove references to k8s.io/klog[v1] * Fix build * Fix go.sum * Update container-builder/builder/kubernetes/builder.go Co-authored-by: Filippe Spolti <[email protected]> * Update container-builder/builder/kubernetes/builder.go Co-authored-by: Filippe Spolti <[email protected]> * Update utils/kubernetes/annotations.go Co-authored-by: Filippe Spolti <[email protected]> * Update controllers/builder/containerbuilder.go Co-authored-by: Filippe Spolti <[email protected]> * Update container-builder/client/fastmapper.go * Update container-builder/common/registry_docker.go Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <[email protected]> * Update controllers/platform/platformutils.go Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <[email protected]> * Update controllers/platform/platformutils.go Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <[email protected]> * Update controllers/platform/platformutils.go Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <[email protected]> --------- Co-authored-by: Michael Anstis <[email protected]> Co-authored-by: Filippe Spolti <[email protected]> Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <[email protected]>
|
Can one of the admins verify this patch? |
ricardozanini
requested review from
davidesalerno and
ricardozanini
and removed request for
desmax74
ricardozanini
approved these changes
Aug 2, 2023
desmax74
approved these changes
Aug 4, 2023
Signed-off-by: Ricardo Zanini <[email protected]>
MarianMacik
pushed a commit
to MarianMacik/kogito-serverless-operator
that referenced
this pull request
Oct 3, 2023
…tests (apache#212) Signed-off-by: Karel Suta <[email protected]>
MarianMacik
pushed a commit
to MarianMacik/kogito-serverless-operator
that referenced
this pull request
Oct 3, 2023
…tests (apache#212) Signed-off-by: Karel Suta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: https://github.com/kiegroup/kogito-serverless-operator/pull/201
Description of the change:
See https://issues.redhat.com/browse/KOGITO-8276
Motivation for the change:
Consolidate logging system.
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.