[KOGITO-9218] - Implement Conditions API and review SonataFlowPlatform #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
changed the title
ricardozanini
force-pushed
the
kogito-9218
branch
from
cf321af
to
e5a8569
Compare
5 tasks
davidesalerno
approved these changes
Aug 4, 2023
desmax74
approved these changes
Aug 4, 2023
…m status Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
force-pushed
the
kogito-9218
branch
from
9af708e
to
8cf4581
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
radtriste
approved these changes
Aug 9, 2023
Merged
5 tasks
MarianMacik
pushed a commit
to MarianMacik/kogito-serverless-operator
that referenced
this pull request
Oct 3, 2023
hack/3.11deploy.sh: - Simplify file globbing logic and adjust exit status to improve user feedback. - Also add feedback for when no deployment files are found. This scenario yields exit code 3, avoiding UNIX reserved exit codes. - Change "*crd.yaml" to "*_crd.yaml" for consistency with other scripts. hack/scorecard.sh: - Simplify globbing with nullglob so no checks are necessary within the loops. - Assign files to a variable so it's not calculated twice unnecessarily. This assumes the files won't be changed within the script or some other program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
In this PR we did:
SonataFlowPlatformstatus with the Kubernetes Conditions API and best practices. There is only one condition type for the static resourceSucceed. Iffalse, we have the field.status.reasonto read the flow.SonataFlowPlatformspec to have two major structuresspec.buildandspec.devMode. Within these two structures, we can now define specifics for these use cases. I think it's clearer now.SonataFlowBuildcontroller to define theImageTagcorrectly. Now, OpenShift Build won't spawn two pods after the first workflow build (cc @radtriste)TODO:
Motivation for the change:
See: https://issues.redhat.com/browse/KOGITO-9218
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.