-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9702] Fix container-builder kaniko build context to consider external resources #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…external resources Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
force-pushed
the
kogito-9702
branch
from
August 21, 2023 19:10
0b7e82b
to
73641b4
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Backporting since OpenShift builds might be compromised. Since builds are not supported for TP1, we don't need to cherry-pick it. |
davidesalerno
approved these changes
Aug 23, 2023
spolti
approved these changes
Aug 23, 2023
radtriste
approved these changes
Aug 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
…external resources (#231) * [KOGITO-9702] Fix container-builder kaniko build context to consider external resources Signed-off-by: Ricardo Zanini <[email protected]> * Mount with subpath to avoid hidden files in the build context Signed-off-by: Ricardo Zanini <[email protected]> * Add SonataFlow resources to kaniko container builder Signed-off-by: Ricardo Zanini <[email protected]> * Enable devmode e2e testing Signed-off-by: Ricardo Zanini <[email protected]> * Fix OpenShift build context files permissions Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]>
5 tasks
ricardozanini
added a commit
that referenced
this pull request
Aug 23, 2023
…external resources (#231) (#240) * [KOGITO-9702] Fix container-builder kaniko build context to consider external resources * Mount with subpath to avoid hidden files in the build context * Add SonataFlow resources to kaniko container builder * Enable devmode e2e testing * Fix OpenShift build context files permissions --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
MarianMacik
pushed a commit
to MarianMacik/kogito-serverless-operator
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Karel Suta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Description of the change:
In this PR, we fix a bug where the internal Kaniko builder won't consider the
SonataFlow
.spec.resources
when building an image.Motivation for the change:
See: https://issues.redhat.com/browse/KOGITO-9702
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.