Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-9702] Fix container-builder kaniko build context to consider external resources #231

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Aug 17, 2023

TODO:

  • - Finish unit tests
  • - Integrate with the main operator module
  • - Do integration tests to verify the new behavior

Description of the change:
In this PR, we fix a bug where the internal Kaniko builder won't consider the SonataFlow .spec.resources when building an image.

Motivation for the change:
See: https://issues.redhat.com/browse/KOGITO-9702

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini marked this pull request as ready for review August 22, 2023 16:31
Signed-off-by: Ricardo Zanini <[email protected]>
@apache apache deleted a comment from kie-ci Aug 22, 2023
@apache apache deleted a comment from kie-ci Aug 22, 2023
@ricardozanini
Copy link
Member Author

Backporting since OpenShift builds might be compromised. Since builds are not supported for TP1, we don't need to cherry-pick it.

@ricardozanini ricardozanini merged commit 907abe5 into apache:main Aug 23, 2023
9 checks passed
@ricardozanini ricardozanini deleted the kogito-9702 branch August 23, 2023 13:46
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
…external resources (#231)

* [KOGITO-9702] Fix container-builder kaniko build context to consider external resources

Signed-off-by: Ricardo Zanini <[email protected]>

* Mount with subpath to avoid hidden files in the build context

Signed-off-by: Ricardo Zanini <[email protected]>

* Add SonataFlow resources to kaniko container builder

Signed-off-by: Ricardo Zanini <[email protected]>

* Enable devmode e2e testing

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix OpenShift build context files permissions

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini added a commit that referenced this pull request Aug 23, 2023
…external resources (#231) (#240)

* [KOGITO-9702] Fix container-builder kaniko build context to consider external resources



* Mount with subpath to avoid hidden files in the build context



* Add SonataFlow resources to kaniko container builder



* Enable devmode e2e testing



* Fix OpenShift build context files permissions



---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
MarianMacik pushed a commit to MarianMacik/kogito-serverless-operator that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants