Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues-308: Operator driven service discovery API Phase2 #309

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Nov 22, 2023

- Add the discovery of kubernetes Deployment, StatefulSet, and Ingress objects to the service discovery API.

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

    - Add the discovery of kubernetes Deployment, StatefulSet, and Ingress objects to the service discovery API.
@wmedvede
Copy link
Contributor Author

Closes: #308

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work man! Just a few observations if you don't mind. 👍

controllers/discovery/discovery.go Outdated Show resolved Hide resolved
controllers/discovery/kubernetes_catalog.go Show resolved Hide resolved
    - Code review suggestions 1, simplify the Deployment and StatefulSet discovery
@wmedvede
Copy link
Contributor Author

@ricardozanini suggestions were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants