-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-10013] Migrate from Minikube to Kind for E2E tests and export logs #354
Merged
ricardozanini
merged 8 commits into
apache:main
from
jordigilh:kogito_10013_migrate_to_kind_in_e2e
Jan 18, 2024
Merged
[KOGITO-10013] Migrate from Minikube to Kind for E2E tests and export logs #354
ricardozanini
merged 8 commits into
apache:main
from
jordigilh:kogito_10013_migrate_to_kind_in_e2e
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
approved these changes
Jan 16, 2024
|
Done. |
jordigilh
force-pushed
the
kogito_10013_migrate_to_kind_in_e2e
branch
from
January 17, 2024 05:10
2cfb5b0
to
ae50e6d
Compare
Signed-off-by: Jordi Gil <[email protected]>
Signed-off-by: Jordi Gil <[email protected]>
…Kind Signed-off-by: Jordi Gil <[email protected]>
…mend github action to use the create cluster target Signed-off-by: Jordi Gil <[email protected]>
jordigilh
force-pushed
the
kogito_10013_migrate_to_kind_in_e2e
branch
from
January 17, 2024 16:26
ae50e6d
to
e151c8e
Compare
Signed-off-by: Jordi Gil <[email protected]>
Signed-off-by: Jordi Gil <[email protected]>
Signed-off-by: Jordi Gil <[email protected]>
Signed-off-by: Jordi Gil <[email protected]>
domhanak
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Jan 29, 2024
… logs (apache#354) * [KOGITO-10013] Migrate from Minikube to Kind for E2E tests Signed-off-by: Jordi Gil <[email protected]> * Add headers and set log retention to minimum (1 day) Signed-off-by: Jordi Gil <[email protected]> * Changed registry port reference to 5001 and reference to Minikube to Kind Signed-off-by: Jordi Gil <[email protected]> * Add makefile targets to install kind, create and delete cluster and amend github action to use the create cluster target Signed-off-by: Jordi Gil <[email protected]> * Load controller built image to node with kind load docker-image Signed-off-by: Jordi Gil <[email protected]> * Remove podman from build process in e2e lane Signed-off-by: Jordi Gil <[email protected]> * Install python's docker libraries: docker and python-docker Signed-off-by: Jordi Gil <[email protected]> * Add docker-squash as pip egg to build the image Signed-off-by: Jordi Gil <[email protected]> --------- Signed-off-by: Jordi Gil <[email protected]>
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Jan 29, 2024
… logs (apache#354) * [KOGITO-10013] Migrate from Minikube to Kind for E2E tests Signed-off-by: Jordi Gil <[email protected]> * Add headers and set log retention to minimum (1 day) Signed-off-by: Jordi Gil <[email protected]> * Changed registry port reference to 5001 and reference to Minikube to Kind Signed-off-by: Jordi Gil <[email protected]> * Add makefile targets to install kind, create and delete cluster and amend github action to use the create cluster target Signed-off-by: Jordi Gil <[email protected]> * Load controller built image to node with kind load docker-image Signed-off-by: Jordi Gil <[email protected]> * Remove podman from build process in e2e lane Signed-off-by: Jordi Gil <[email protected]> * Install python's docker libraries: docker and python-docker Signed-off-by: Jordi Gil <[email protected]> * Add docker-squash as pip egg to build the image Signed-off-by: Jordi Gil <[email protected]> --------- Signed-off-by: Jordi Gil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change:
Migrating to Kind will allow us to retrieve a concise log report of the running containers in the cluster when an E2E test fails.
PR also adds 2 new steps in the e2e to export the cluster logs
@ricardozanini @masayag @wmedvede PTAL.