Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-10013] Migrate from Minikube to Kind for E2E tests and export logs #354

Merged

Conversation

jordigilh
Copy link
Contributor

Motivation for the change:

Migrating to Kind will allow us to retrieve a concise log report of the running containers in the cluster when an E2E test fails.

PR also adds 2 new steps in the e2e to export the cluster logs

@ricardozanini @masayag @wmedvede PTAL.

.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@ricardozanini
Copy link
Member

make addheaders :P

@jordigilh
Copy link
Contributor Author

make addheaders :P

Done.

@jordigilh jordigilh force-pushed the kogito_10013_migrate_to_kind_in_e2e branch from 2cfb5b0 to ae50e6d Compare January 17, 2024 05:10
@jordigilh jordigilh force-pushed the kogito_10013_migrate_to_kind_in_e2e branch from ae50e6d to e151c8e Compare January 17, 2024 16:26
@ricardozanini ricardozanini merged commit a8dc5ed into apache:main Jan 18, 2024
4 checks passed
@domhanak domhanak self-requested a review January 18, 2024 13:33
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
… logs (apache#354)

* [KOGITO-10013] Migrate from Minikube to Kind for E2E tests

Signed-off-by: Jordi Gil <[email protected]>

* Add headers and set log retention to minimum (1 day)

Signed-off-by: Jordi Gil <[email protected]>

* Changed registry port reference to 5001 and reference to Minikube to Kind

Signed-off-by: Jordi Gil <[email protected]>

* Add makefile targets to install kind, create and delete cluster and amend github action to use the create cluster target

Signed-off-by: Jordi Gil <[email protected]>

* Load controller built image to node with kind load docker-image

Signed-off-by: Jordi Gil <[email protected]>

* Remove podman from build process in e2e lane

Signed-off-by: Jordi Gil <[email protected]>

* Install python's docker libraries: docker and python-docker

Signed-off-by: Jordi Gil <[email protected]>

* Add docker-squash as pip egg to build the image

Signed-off-by: Jordi Gil <[email protected]>

---------

Signed-off-by: Jordi Gil <[email protected]>
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
… logs (apache#354)

* [KOGITO-10013] Migrate from Minikube to Kind for E2E tests

Signed-off-by: Jordi Gil <[email protected]>

* Add headers and set log retention to minimum (1 day)

Signed-off-by: Jordi Gil <[email protected]>

* Changed registry port reference to 5001 and reference to Minikube to Kind

Signed-off-by: Jordi Gil <[email protected]>

* Add makefile targets to install kind, create and delete cluster and amend github action to use the create cluster target

Signed-off-by: Jordi Gil <[email protected]>

* Load controller built image to node with kind load docker-image

Signed-off-by: Jordi Gil <[email protected]>

* Remove podman from build process in e2e lane

Signed-off-by: Jordi Gil <[email protected]>

* Install python's docker libraries: docker and python-docker

Signed-off-by: Jordi Gil <[email protected]>

* Add docker-squash as pip egg to build the image

Signed-off-by: Jordi Gil <[email protected]>

---------

Signed-off-by: Jordi Gil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants