Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kogito-serverless-operator-353: Enable the sending of the process definition event when the data-index is present #358

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

wmedvede
Copy link
Contributor

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…inition event when the data-index is present
@wmedvede
Copy link
Contributor Author

wmedvede commented Jan 19, 2024

Would my mind review guys @ricardozanini , @jakubschwan

Silly quick-win but we need to avoid start adding manual configs for the Parodos workflows.

This basically

  1. incoporates the mp.messaging.outgoing.kogito-processdefinitions-events.url properly configured when the DI and JS are
    deployed by using the sonataflow-platform
  2. incoporates the kogito.service.url for the DI and JS when deployed by using the sonataflow-platform
  3. removes the no longer used kogito.events.variables.enabled property

Tests are adjusted accordingly

Thanks!

@ricardozanini ricardozanini requested review from domhanak and removed request for jakubschwan January 19, 2024 12:51
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! And thank you for the naming refactoring!

@ricardozanini
Copy link
Member

@domhanak can you please prioritize this?

@wmedvede wmedvede merged commit 95cee15 into apache:main Jan 23, 2024
4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the sending of the process definition event when the data-index is present
3 participants