Fixes kind create cluster script that contained a hardcoded IP #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordigilh
force-pushed
the
fix/kind_hardcoded_ip_in_config
branch
from
2072186
to
ace8a88
Compare
|
Can you please rebase your fork? 🙏 |
…e registry configuration in containerd. Instead it now uses the associated IP of the registry container running in Docker Signed-off-by: Jordi Gil <[email protected]>
jordigilh
force-pushed
the
fix/kind_hardcoded_ip_in_config
branch
from
ace8a88
to
e6f214e
Compare
domhanak
approved these changes
Feb 5, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Mar 11, 2024
…e registry configuration in containerd. Instead it now uses the associated IP of the registry container running in Docker (apache#383) Signed-off-by: Jordi Gil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a hardcoded IP that defined the directory inside
/etc/containerdfor the registry configuration. When the IPs mismatched it caused a failure to pull or push images from the insecure registry via kaniko builder with Kind. The correct approach is to use the IP from the docker network configuration for the registry container for both the directory name and the configuration contained within.@wmedvede @ricardozanini PTAL.