-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[380] enhance SonataFlowClusterPlatform.spec #389
Conversation
affdb18
to
3155201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But, unless we are sure that other "capabilities" will managed at cluster level in the short term, and we have them more or less identified, I don't see why we need this.
I mean, right now, if you defile a SFCP is because you want to make DI and JS cluster wide, so, if you don't won't this capability, you don't define a SFCP, that's it.
@ricardozanini @tchughesiv would you mind guys elaborate which other capabilities we are going to define at cluster level and how they will work?
@wmedvede we can't preview the future atm, @wmedvede. But the core engine is already based on those capabilities in the form of Quarkus extensions. So, for instance, I can see cluster-level messaging, persistence, monitoring, and so on in the future. So leaving the API capable of accommodating those is the intention of this PR. |
@tchughesiv any plans to add E2E tests to this PR? So far there are none for this controller. |
@jordigilh @ricardozanini should i add them to this PR or a separate one? |
Any reason for not adding them to this PR already? Perhaps dependencies to other unmerged PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jordigilh let me see what i can do |
718b30b
to
85ae627
Compare
@jordigilh @ricardozanini i've added e2e tests |
6d96179
to
c01b27b
Compare
@tchughesiv can you please rebase? |
Signed-off-by: Tommy Hughes <[email protected]>
@ricardozanini done |
Signed-off-by: Tommy Hughes <[email protected]>
Description of the change:
Enhance SonataFlowClusterPlatform.spec to better communicate which platform capabilities are being used by workflows cluster-wide. If
spec.capabilities = nil
, defaults tocapabilities.workflows["services"]
.Motivation for the change:
fixes #380
There are 2 goals in mind -
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.