Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to ensure Data Index readiness #397

Closed
wants to merge 1 commit into from

Conversation

masayag
Copy link
Contributor

@masayag masayag commented Feb 15, 2024

Description of the change:
By adding a property kogito.events.processdefinitions.errors.propagate to the workflow's managed properties, the workflow will be restarted if failed to communicate with the Data Index.

Motivation for the change:
Verifying the workflow isn't reported as ready before reaching out to the Data Index and successfully publishing its process definition.

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

By adding a property kogito.events.processdefinitions.errors.propagate
to the workflow's managed properties, the workflow will be restarted if
failed to communicate with the Data Index.

Signed-off-by: Moti Asayag <[email protected]>
@masayag
Copy link
Contributor Author

masayag commented Feb 15, 2024

Duplicate of #396

@masayag masayag closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant