Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 471] Enhance Makefile to allow catalog source image on MacBook M2 #472

Merged
merged 1 commit into from
May 29, 2024

Conversation

jianrongzhang89
Copy link
Contributor

Description of the change:
Currently the Makefile does not support cross-platform build for the catalog source. As a result, if I build the image on MacBook with M2 chip, the catalog source will fail as the opm included in the image is not in the linux/amd64 architecture.

The Makefile is enhanced to build the catalog source image in linux/amd64 architecture on a machine that has a different architecture.

Motivation for the change:
Cross-platform build is not supported currently for catalog source.

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

database/index.db Outdated Show resolved Hide resolved
@ricardozanini ricardozanini merged commit 5eb743c into apache:main May 29, 2024
4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants