Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for workflowproj/operator.go #508

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

rgolangh
Copy link
Contributor

Signed-off-by: Roy Golan [email protected]

@rgolangh
Copy link
Contributor Author

@wmedvede more coverage for the lables work

@wmedvede
Copy link
Contributor

@rgolangh looks like make generate-all is required here maybe?

@rgolangh
Copy link
Contributor Author

@rgolangh looks like make generate-all is required here maybe?

yes forgot that, thanks. Fixing

@wmedvede wmedvede self-requested a review July 25, 2024 17:09
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgolangh do you think you can get back to this PR?

@ricardozanini
Copy link
Member

@rgolangh cau you please rebase?

@ricardozanini ricardozanini merged commit c42d3e0 into apache:main Aug 9, 2024
4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants