Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sonataflow postgres db migrator tool for data index and jobs service #517

Merged
merged 9 commits into from
Aug 29, 2024

Conversation

rhkp
Copy link
Contributor

@rhkp rhkp commented Aug 8, 2024

Closes #516 : Add data index/jobs service postgres database migrator tool

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the efforts so far. Can you please also add unit tests to the application and create a GitHub action in a separate file that runs only when there's a change in this directory to run the tests?

@rhkp
Copy link
Contributor Author

rhkp commented Aug 13, 2024

Great work! Thanks for the efforts so far. Can you please also add unit tests to the application and create a GitHub action in a separate file that runs only when there's a change in this directory to run the tests?

Hi @ricardozanini
I think all comments have been addressed now. Please advise of any more changes or please acknowledge and merge.
Thanks.

images/tools/sonataflow-db-migrator/pom.xml Outdated Show resolved Hide resolved
images/tools/sonataflow-db-migrator/pom.xml Outdated Show resolved Hide resolved
@ricardozanini
Copy link
Member

@rhkp you might need to rebase your branch.

@rhkp
Copy link
Contributor Author

rhkp commented Aug 29, 2024

@jakubschwan @ricardozanini Not sure are there any more comments? If not can we please approve/merge?

@ricardozanini ricardozanini merged commit 1e7aad1 into apache:main Aug 29, 2024
5 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data index/jobs service postgres database migrator tool
3 participants