PLANNER-2932 fix impact assertion in constraint verifier #2947
Conversation
lucamolteni
force-pushed
the
fix/PLANNER-2932-impact-score-verification
branch
from
2869946
to
ae4506e
Compare
|
@RobJohansen there are a few failed test can you double check? |
RobJohansen
force-pushed
the
fix/PLANNER-2932-impact-score-verification
branch
from
ae4506e
to
623d913
Compare
Apologies, I've now seen the failing test and I'm re-assessing what the intention of the implementation is and whether this is a correct fix. I will update once I have done so, thanks. |
RobJohansen
force-pushed
the
fix/PLANNER-2932-impact-score-verification
branch
from
d9a6cf3
to
aa257cd
Compare
|
@lucamolteni It took a while to understand the intention of the tests in SingleConstraintAssertionTest but found the issue and rectified. Renamed "A" and "B" to "REWARD" and "PENALIZE" respectively, so that its a little clearer. |
Thanks, once we finalize this apache migration I'll merge it |
RobJohansen
force-pushed
the
fix/PLANNER-2932-impact-score-verification
branch
from
aa257cd
to
00186dd
Compare
|
The PR check has been mistakenly triggered for this PR again from testing location, you can disregard the failure, it was green earlier. @lucamolteni Sorry for the mess. |
lucamolteni
force-pushed
the
fix/PLANNER-2932-impact-score-verification
branch
from
00186dd
to
0139139
Compare
JIRA
https://issues.redhat.com/browse/PLANNER-2932
Issue
Constraint Verifier gives unexpected result when verifying a constraint terminating with impact() (i.e. MIXED score type).
Resolution
Invert PENALTY and REWARD branches of switch.