review feedback

apache · Sep 19, 2024 · 302ec19 · 302ec19
1 parent dd67a91
commit 302ec19
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/dmn-editor/src/diagram/connections/isValidConnection.ts b/packages/dmn-editor/src/diagram/connections/isValidConnection.ts
@@ -50,7 +50,8 @@ export function _checkIsValidConnection(
 
   // External nodes cannot be targeted by default
   // However there are exceptions, for example adding a waypoint on the edge
-  if (!extraArg?.allowExternalTarget && targetNode.data.dmnObjectQName.prefix) {
+  const isExternalNode = targetNode.data.dmnObjectQName.prefix != undefined;
+  if (!extraArg?.allowExternalTarget && isExternalNode) {
     return false;
   }