post review

apache · Sep 3, 2024 · 4a74a51 · 4a74a51
1 parent 663162b
commit 4a74a51
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/packages/kn-plugin-workflow/pkg/command/quarkus/deploy.go b/packages/kn-plugin-workflow/pkg/command/quarkus/deploy.go
@@ -95,6 +95,7 @@ func runDeploy(cmd *cobra.Command, args []string) error {
 	}
 
 	if _, err = deployKnativeServiceAndEventingBindings(cfg); err != nil {
+		fmt.Println("❌ ERROR:Deploy failed, Knative Eventing binding was not created.")
 		return err
 	}
 

diff --git a/...ages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex2-custom-namespace.yml b/...ages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex2-custom-namespace.yml
@@ -19,7 +19,7 @@ metadata:
   name: example-cronjob
   namespace: mycustom
 spec:
-  schedule: "*/5 * * * *" # Запуск каждые 5 минут
+  schedule: "*/5 * * * *"
   jobTemplate:
     spec:
       template:

diff --git a/packages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex2.yml b/packages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex2.yml
@@ -19,7 +19,7 @@ metadata:
   name: example-cronjob
   namespace: default
 spec:
-  schedule: "*/5 * * * *" # Запуск каждые 5 минут
+  schedule: "*/5 * * * *"
   jobTemplate:
     spec:
       template:

diff --git a/...ages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex3-custom-namespace.yml b/...ages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex3-custom-namespace.yml
@@ -19,7 +19,7 @@ metadata:
   name: example-cronjob
   namespace: mycustom
 spec:
-  schedule: "*/5 * * * *" # Запуск каждые 5 минут
+  schedule: "*/5 * * * *"
   jobTemplate:
     spec:
       template:

diff --git a/packages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex3.yml b/packages/kn-plugin-workflow/pkg/command/quarkus/testdata/kogito-complex3.yml
@@ -19,7 +19,7 @@ metadata:
   name: example-cronjob
   namespace: default
 spec:
-  schedule: "*/5 * * * *" # Запуск каждые 5 минут
+  schedule: "*/5 * * * *"
   jobTemplate:
     spec:
       template: