allowExternalTarget refactoring

apache · Sep 13, 2024 · dda9611 · dda9611
1 parent fb13967
commit dda9611
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/dmn-editor/src/diagram/connections/isValidConnection.ts b/packages/dmn-editor/src/diagram/connections/isValidConnection.ts
@@ -40,15 +40,17 @@ export function _checkIsValidConnection(
   sourceNode: { type?: string; data: DmnDiagramNodeData } | undefined,
   targetNode: { type?: string; data: DmnDiagramNodeData } | undefined,
   edgeType: string | null | undefined,
-  allowExternalTarget?: boolean
+  extraArg?: {
+    allowExternalTarget: boolean;
+  }
 ) {
   if (!sourceNode?.type || !targetNode?.type || !edgeType) {
     return false;
   }
 
   // External nodes cannot be targeted by default
   // However there are exceptions, for example adding a waypoint on the edge
-  if (!allowExternalTarget && targetNode.data.dmnObjectQName.prefix) {
+  if (!extraArg?.allowExternalTarget && targetNode.data.dmnObjectQName.prefix) {
     return false;
   }
 

diff --git a/packages/dmn-editor/src/mutations/addEdge.ts b/packages/dmn-editor/src/mutations/addEdge.ts
@@ -227,7 +227,7 @@ export function addEdgeTargetingExternalNode({
   keepWaypoints: boolean;
   existingEdgeId?: string;
 }) {
-  if (!_checkIsValidConnection(sourceNode, targetNode, edge.type, true)) {
+  if (!_checkIsValidConnection(sourceNode, targetNode, edge.type, { allowExternalTarget: true })) {
     throw new Error(`DMN MUTATION: Invalid structure: (${sourceNode.type}) --${edge.type}--> (${targetNode.type}) `);
   }