kie-issues#130: chrome-extension: Kogito icon is not working correctly after using the browser "back" #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbowers-ibm
requested review from
ederign,
tiagobento and
paulovmr
as code owners
tiagobento
changed the title
ljmotta
reviewed
Jan 30, 2024
Comment on lines
+168
to
+174
| export function cleanupDuplicateElements(id: string, selectors: string[]) { | ||
| selectors.forEach((selector) => { | ||
| Array.from(document.querySelectorAll(`.${selector}.${id}`)).forEach((e) => { | ||
| removeAllChildren(e); | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Currently this function is receiving classes and building a selector in a strictly way. You could improve this function by building the selectors before passing it down to the function. This way the caller can pass down a different selector if required.
There was a problem hiding this comment.
Good point thanks Luiz, will update it accordingly
|
After merging with main, the fix no longer works due to a bug apache/incubator-kie-issues#899. Probably best not to merge until the bug is resolved. |
|
may I ask you to include me into reviewers once ready? I would like to doble check effect of the changes for the different github instances |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes apache/incubator-kie-issues#130
Blocked by: