Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Make sure kie-tools is using the latest timestamped SNAPSHOT from Kogito (999-20240411-SNAPSHOT) #2229

Merged
merged 22 commits into from
Apr 12, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented Apr 7, 2024

Update all Kogito references to 999-20240411-SNAPSHOT

@yesamer yesamer added area:dependencies Pull requests that update a dependency file area:core labels Apr 7, 2024
# Conflicts:
#	packages/sonataflow-quarkus-devui/pom.xml
@yesamer yesamer changed the title kie-issues#965-2 kie-issues#965-2: Make sure kie-tools is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT) Apr 7, 2024
Copy link
Contributor

@tiagobento tiagobento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we have different dates for the images... Could we unify?

packages/stunner-editors/pom.xml Outdated Show resolved Hide resolved
packages/kn-plugin-workflow/env/index.js Outdated Show resolved Hide resolved
@yesamer
Copy link
Contributor Author

yesamer commented Apr 8, 2024

@tiagobento At this time, the latest version of the image https://quay.io/repository/kiegroup/kogito-base-builder-nightly?tab=tags&tag=latest is 2024-04-05

@tiagobento
Copy link
Contributor

tiagobento commented Apr 8, 2024

@ricardozanini Any idea what could've happened with the nightly build of this image?

@ricardozanini
Copy link
Member

@yesamer @tiagobento this image has been removed as part of the old operator archiving: apache/incubator-kie-kogito-images#1748

@ricardozanini
Copy link
Member

If you want, I think I can help review these PRs related to images. Let me know!

@yesamer yesamer changed the title kie-issues#965-2: Make sure kie-tools is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT) NO-ISSUE: Make sure kie-tools is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT) Apr 9, 2024
@yesamer
Copy link
Contributor Author

yesamer commented Apr 9, 2024

@tiagobento @thiagoelg That means we need a replacement for that... Should I open a ticket?

@ricardozanini
Copy link
Member

@yesamer why do you need a replacement? That image won't be used anywhere as far as I know.

@tiagobento
Copy link
Contributor

@ricardozanini It is used by Serverless Logic Web Tools, it seems like... cc @caponetto

@paulovmr
Copy link
Member

paulovmr commented Apr 9, 2024

@ricardozanini @tiagobento yes this image was the base for the web tools builder and dev-mode images. @ricardozanini could it be restored?

@ricardozanini
Copy link
Member

@paulovmr yes, we can. I can't do it today, if some of you have some room, here's the PR where I removed it: https://github.com/apache/incubator-kie-kogito-images/pull/1748/files

@ricardozanini
Copy link
Member

@paulovmr @caponetto honestly, I saw the image now and I'm not seeing anything that it's not on openjdk-17 images. Why not use it directly?

@yesamer
Copy link
Contributor Author

yesamer commented Apr 11, 2024

@rodrigonull Great!!!! Are you launching the job for all our repos? jit-executor as well? Thank you!

@rodrigonull
Copy link
Contributor

@yesamer yes, my plan is to trigger all jobs including the JIT executor.

@tiagobento
Copy link
Contributor

@yesamer For images, please change the tags to 999-YYYYMMDD instead of main-*, as the first comes from the weekly jobs (dependencies are also timestamped SNAPSHOTs) and the second is from daily jobs (dependencies are 999-SNAPSHOT)

@yesamer yesamer changed the title NO-ISSUE: Make sure kie-tools is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT) NO-ISSUE: Make sure kie-tools is using the latest timestamped SNAPSHOT from Kogito (999-20240411-SNAPSHOT) Apr 12, 2024
@yesamer
Copy link
Contributor Author

yesamer commented Apr 12, 2024

@tiagobento Done!

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yesamer
Out of curiosity: would not be possible to store that variable in one single place, and maybe refer to it wherever is needed ?

@tiagobento
Copy link
Contributor

@gitgabrio That's the idea behind https://github.com/apache/incubator-kie-tools/blob/main/packages/root-env/env/index.js#L53-L60, but it's not always simple to do it, especially when the format changes slightly :)

@yesamer
Copy link
Contributor Author

yesamer commented Apr 12, 2024

@gitgabrio I guess @tiagobento can give you a better answer than me, anyway my feeling is that is it possible to remove some of those places, and the tooling team is already committed to that. In this PR I removed one place :)

@yesamer
Copy link
Contributor Author

yesamer commented Apr 12, 2024

@tiagobento Can I merge it? :)

@tiagobento
Copy link
Contributor

@yesamer There's only one approve :( We need 2.

In the mean time...... could we remove KN_PLUGIN_WORKFLOW__quarkusVersion and KN_PLUGIN_WORKFLOW__kogitoVersion? We can use the one from root-env instead of having two variables dedicated to the kn-plugin-workflow.. and we @paulovmr's blessing :)

@yesamer
Copy link
Contributor Author

yesamer commented Apr 12, 2024

@tiagobento Right.

So should I just remove KN_PLUGIN_WORKFLOW__kogitoVersion and replace it with kogitoRuntime.version, correct?

@tiagobento
Copy link
Contributor

@yesamer Yes!

@tiagobento
Copy link
Contributor

@yesamer Looks like this one can be removed too! SERVERLESS_LOGIC_WEB_TOOLS__kogitoVersion cc @paulovmr

@tiagobento
Copy link
Contributor

@yesamer And this one too! SERVERLESS_LOGIC_WEB_TOOLS__quarkusPlatformVersion.

This is the last comment I promise 😅

@tiagobento
Copy link
Contributor

I bet @gitgabrio is thrilled with us removing env vars, though :)

@yesamer
Copy link
Contributor Author

yesamer commented Apr 12, 2024

BINGO!

@yesamer
Copy link
Contributor Author

yesamer commented Apr 12, 2024

Done! @tiagobento @gitgabrio @kbowers-ibm

@tiagobento tiagobento merged commit 8a9cfdc into apache:main Apr 12, 2024
8 checks passed
fantonangeli pushed a commit to fantonangeli/kie-tools that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core area:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants