-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Make sure kie-tools
is using the latest timestamped SNAPSHOT from Kogito (999-20240411-SNAPSHOT)
#2229
Conversation
# Conflicts: # packages/sonataflow-quarkus-devui/pom.xml
kie-tools
is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed we have different dates for the images... Could we unify?
@tiagobento At this time, the latest version of the image https://quay.io/repository/kiegroup/kogito-base-builder-nightly?tab=tags&tag=latest is 2024-04-05 |
@ricardozanini Any idea what could've happened with the nightly build of this image? |
@yesamer @tiagobento this image has been removed as part of the old operator archiving: apache/incubator-kie-kogito-images#1748 |
If you want, I think I can help review these PRs related to images. Let me know! |
kie-tools
is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT)kie-tools
is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT)
@tiagobento @thiagoelg That means we need a replacement for that... Should I open a ticket? |
@yesamer why do you need a replacement? That image won't be used anywhere as far as I know. |
@ricardozanini It is used by Serverless Logic Web Tools, it seems like... cc @caponetto |
@ricardozanini @tiagobento yes this image was the base for the web tools builder and dev-mode images. @ricardozanini could it be restored? |
@paulovmr yes, we can. I can't do it today, if some of you have some room, here's the PR where I removed it: https://github.com/apache/incubator-kie-kogito-images/pull/1748/files |
@paulovmr @caponetto honestly, I saw the image now and I'm not seeing anything that it's not on openjdk-17 images. Why not use it directly? |
@rodrigonull Great!!!! Are you launching the job for all our repos? jit-executor as well? Thank you! |
@yesamer yes, my plan is to trigger all jobs including the JIT executor. |
@yesamer For images, please change the tags to 999-YYYYMMDD instead of main-*, as the first comes from the weekly jobs (dependencies are also timestamped SNAPSHOTs) and the second is from daily jobs (dependencies are 999-SNAPSHOT) |
kie-tools
is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT)kie-tools
is using the latest timestamped SNAPSHOT from Kogito (999-20240411-SNAPSHOT)
@tiagobento Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yesamer
Out of curiosity: would not be possible to store that variable in one single place, and maybe refer to it wherever is needed ?
@gitgabrio That's the idea behind https://github.com/apache/incubator-kie-tools/blob/main/packages/root-env/env/index.js#L53-L60, but it's not always simple to do it, especially when the format changes slightly :) |
@gitgabrio I guess @tiagobento can give you a better answer than me, anyway my feeling is that is it possible to remove some of those places, and the tooling team is already committed to that. In this PR I removed one place :) |
@tiagobento Can I merge it? :) |
@tiagobento Right. So should I just remove KN_PLUGIN_WORKFLOW__kogitoVersion and replace it with |
@yesamer Yes! |
@yesamer And this one too! This is the last comment I promise 😅 |
I bet @gitgabrio is thrilled with us removing env vars, though :) |
BINGO! |
…HOT from Kogito (999-20240411-SNAPSHOT) (apache#2229)
Update all Kogito references to
999-20240411-SNAPSHOT