NO-ISSUE: kogito-swf-{builder/devmode} images should build the nightly tags by default but also be configurable
#2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoelg
requested review from
ederign,
tiagobento and
paulovmr
as code owners
tiagobento
reviewed
Apr 29, 2024
Comment on lines
+127
to
+133
| ls -la "${KOGITO_HOME}"/.m2/repository/org/apache/kie/ | ||
| ls -la "${KOGITO_HOME}"/.m2/repository/org/kie/ | ||
|
|
||
| # mkdir .mvn | ||
| touch .mvn/maven.config | ||
| echo " -Dversion.org.kie.kogito=${KOGITO_VERSION} -Dquarkus.platform.version=${QUARKUS_PLATFORM_VERSION}" >> .mvn/maven.config | ||
|
|
There was a problem hiding this comment.
@pefernan @jstastny-cz This is what can be removed once we fix maven-base.
tiagobento
reviewed
Apr 29, 2024
Comment on lines
+22
to
+30
| # mvn install:install-file \ | ||
| # -Dfile=/tmp/artifacts/sonataflow-quarkus-devui.jar \ | ||
| # -DgroupId=org.apache.kie.sonataflow \ | ||
| # -DartifactId=sonataflow-quarkus-devui \ | ||
| # -Dversion=$SONATAFLOW_QUARKUS_DEVUI_VERSION \ | ||
| # -Dpackaging=jar \ | ||
| # -DgeneratePom=true | ||
|
|
||
| ls -la /tmp/artifacts |
There was a problem hiding this comment.
@pefernan @jstastny-cz This too can go.
tiagobento
reviewed
Apr 29, 2024
| tar xf /tmp/artifacts/sonataflow-quarkus-devui-maven-repo.tar -C "${KOGITO_HOME}"/.m2/repository/org/apache/kie/ | ||
| tar xf /tmp/artifacts/kie-tools-maven-base-maven-repo.tar -C "${KOGITO_HOME}"/.m2/repository/org/kie/ | ||
|
|
||
| find "${KOGITO_HOME}"/.m2/repository -name _remote.repositories | xargs rm |
There was a problem hiding this comment.
@pefernan @jstastny-cz This is necessary for Maven to not try and use a remote version of this, since in development this is a SNAPSHOT version. Let me know if you see a problem with this.
|
@pefernan @thiagoelg Guys, I'll close this because all of this changes are already present on we can proceed by merging it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also in this PR: