Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#1173: Retrieve workflow definitions from data index instead of openapi.json #2302

Merged
merged 5 commits into from
May 28, 2024
Merged

kie-issues#1173: Retrieve workflow definitions from data index instead of openapi.json #2302

merged 5 commits into from
May 28, 2024

Conversation

paulovmr
Copy link
Member

@paulovmr paulovmr commented May 7, 2024

fantonangeli
fantonangeli requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@fantonangeli fantonangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulovmr Thank you for your PR.
I left 2 comments about kogitoServiceUrl which should be needed to send the data to the workflow, but overall looks good.

packages/runtime-tools-swf-gateway-api/src/gatewayApi/apis.tsx Show resolved Hide resolved
...-logic-web-tools/src/runtimeTools/contexts/WebToolsWorkflowDefinitionListContextProvider.tsx Show resolved Hide resolved
@caponetto
Copy link
Contributor

@paulovmr do we still need to set up this field?
All the info you need is present on the Data Index, including the Service URLs.

image

@caponetto
Copy link
Contributor

@fantonangeli I think we'll need a similar improvement to the SonataFlow web app. WDYT?

@fantonangeli
Copy link
Contributor

@fantonangeli I think we'll need a similar improvement to the SonataFlow web app. WDYT?

Yes, I agree

@paulovmr paulovmr added the pr: DO NOT MERGE Draft PR, not ready for merging label May 9, 2024
@pefernan
Copy link
Contributor

hi @paulovmr ! Would it be possible to bring this to the jbpm-quarkus-devui too??

@paulovmr
Copy link
Member Author

hi @pefernan ! Sure, I'm doing some other changes in the web tools UI to wrap up this PR, but after I can send one with similar changes to the current ones for jbpm as well.

@paulovmr paulovmr added pr: waiting-for-review Waiting for peer reviews and removed pr: DO NOT MERGE Draft PR, not ready for merging labels May 27, 2024
caponetto
caponetto reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left only one minor comment.

packages/serverless-logic-web-tools/src/navigation/Routes.ts Outdated Show resolved Hide resolved
@fantonangeli
Copy link
Contributor

LGTM and tested locally.
Only one question: do we want to update SonataFlow Deployment Webapp in this PR or in a separate PR?

incubator-kie-tools/packages/sonataflow-deployment-webapp/src/pages/Workflows/Workflows.tsx

Line 43 in e35af74

if (openApi.openApiPromise.status === PromiseStateStatus.REJECTED) {

@paulovmr @caponetto
Removed unused commented code
97fa34c 
Co-authored-by: Guilherme Caponetto <[email protected]>
@paulovmr
Copy link
Member Author

@fantonangeli Thanks, I've created apache/incubator-kie-issues#1276 to tackle the sonataflow-deployment-webapp separately.

@paulovmr paulovmr removed the pr: waiting-for-review Waiting for peer reviews label May 28, 2024
@paulovmr paulovmr merged commit 9c1f321 into apache:main May 28, 2024
14 checks passed
fantonangeli pushed a commit to fantonangeli/kie-tools that referenced this pull request May 29, 2024
@paulovmr @caponetto @fantonangeli
kie-issues#1173: Retrieve workflow definitions from data index instea…
f96a287 
…d of openapi.json (apache#2302)

Co-authored-by: Guilherme Caponetto <[email protected]>
fantonangeli added a commit to fantonangeli/kie-tools that referenced this pull request May 29, 2024
@fantonangeli
Aligned the code to pull apache#2302
bae7a82
@fantonangeli fantonangeli mentioned this pull request Jun 7, 2024
Merged
fantonangeli added a commit to fantonangeli/kie-tools that referenced this pull request Jun 14, 2024
@fantonangeli @paulovmr @caponetto
kie-issues#1060: Create Sonataflow management console webapp (#24)
f789d64 
* Add WorkflowDefinitions page

* Add WorkflowForm page

* add WorkflowInstances

* Add WorkflowDetails

* add TriggerCloudEvent

* Apply PR:  NO-ISSUE: Add url package everywhere stream-http is used apache#2301

* add MonitoringPage

* Renamed pages

* rm EmptyPage

* Fix lint warnings

* styles

* Monitoring webapp configuration

* Commit defaultEnvJson

* Configured monitoring-webapp and HashRouter

* Add sonataflow-realm.json

* kie-issues#1173: Retrieve workflow definitions from data index instead of openapi.json (apache#2302)

Co-authored-by: Guilherme Caponetto <[email protected]>

* Aligned the code to pull apache#2302

* Removed use of sonataflowOpenApiBaseUrl

* Fix merge errors

---------

Co-authored-by: Paulo Martins <[email protected]>
Co-authored-by: Guilherme Caponetto <[email protected]>
@fantonangeli fantonangeli mentioned this pull request Aug 21, 2024
Closed
@fantonangeli fantonangeli mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantonangeli fantonangeli fantonangeli approved these changes

@caponetto caponetto caponetto approved these changes

@ederign ederign Awaiting requested review from ederign

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

Assignees
No one assigned
Labels
area:sonataflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve workflow definitions from data index instead of openapi.json
5 participants
@paulovmr @caponetto @fantonangeli @pefernan @tiagobento