Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1163: incubator-kie-tools missing header files (Part III) #2307

Merged
merged 33 commits into from
May 11, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented May 9, 2024

Closes apache/incubator-kie-issues#1163

Headers added in:

  • All *.md files
  • All pom.xml files
  • All *.properties files
  • All *.scesim files
  • All *.bpmn & *.bpmn2` files
  • All *.pmml files
  • All *.dmn files
  • All *.yaml & *.yml
    files
  • All *.sh files
  • All *.xml files

Some yaml files have been ignored because autogenerated.

@porcelli @LightGuard @Josephblt

@porcelli
Copy link
Contributor

porcelli commented May 9, 2024

@yesamer we had some build failures =/

@yesamer
Copy link
Contributor Author

yesamer commented May 9, 2024

@tiagobento Do you know the reason for those git diffs against the yaml file I modified?

@thiagoelg
Copy link
Member

@tiagobento Do you know the reason for those git diffs against the yaml file I modified?

Probably because these files are auto-generated.

I know that in kogito-serverless-operator there's a script that adds headers to these files, not sure why it's not working, I'll take a look.

For the helm charts files, we need to add these headers after generating them somehow.

@porcelli
Copy link
Contributor

porcelli commented May 9, 2024

generated files do not need license headers... can we document what are the generated files?

@yesamer
Copy link
Contributor Author

yesamer commented May 9, 2024

Thank you @thiagoelg!

Based on that, I guess can we ignore them @porcelli, right?

@porcelli
Copy link
Contributor

porcelli commented May 9, 2024

correct, would need just to document - ideally adding to NOTICE file

@yesamer yesamer merged commit a935f6b into apache:main May 11, 2024
19 checks passed
@yesamer yesamer deleted the headers-3 branch May 11, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incubator-kie-tools missing header files
5 participants