Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1285: Remove unnecessary base image from quarkus examples (quay.io/kiegroup/kogito-runtime-jvm:latest) #2457

Conversation

Copy link
Contributor

@tiagobento tiagobento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @fantonangeli !

packages/sonataflow-operator/version/version.go Outdated Show resolved Hide resolved
packages/sonataflow-operator/version/version.go Outdated Show resolved Hide resolved
@domhanak domhanak self-requested a review July 4, 2024 06:47
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the referenced PR from examples I see;
registry.access.redhat.com/ubi9/openjdk-17:1.18

but in this PR I see:
registry.access.redhat.com/ubi9/openjdk-17:1.20

Please check, imho they should match

@fantonangeli
Copy link
Contributor Author

@domhanak
I used the "1.20" to keep consistency with other places in kie-tools, which uses "1.20", but I can change this PR to "1.18".

Otherwise, we need to update the version in kogito-examples where it is used in 18 places.
WDYT?

@tiagobento
Copy link
Contributor

If we can upgrade to a newer version, then I think we should... @fantonangeli @domhanak... +1 for consistency too.

@domhanak
Copy link
Contributor

domhanak commented Jul 8, 2024

@fantonangeli imho we update also examples if no issues, we should aim having this consistent

@fantonangeli
Copy link
Contributor Author

@tiagobento @domhanak good, I will prepare the kogito-example update PR

@fantonangeli
Copy link
Contributor Author

kogito-examples update PR: apache/incubator-kie-kogito-examples#1980

@tiagobento tiagobento merged commit 33adc67 into apache:main Jul 8, 2024
14 checks passed
@fantonangeli fantonangeli deleted the kie-issues#1285-Remove-unnecessary-base-image-from-quarkus-examples-quayiokiegroupkogito-runtime-jvmlatest branch July 9, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants